Skip to content

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Aug 22, 2022

Overview

Small fix: fixes aXe violations related to not having a <main> element.

Medium feature/fix: adds a link option per #326.

Larger fix: uses proper <label> & <menu> elements and attributes in UserWrappr menus. Uses a <LabeledOption> component to set up labels.

PR Checklist

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review August 22, 2022 15:21
@JoshuaKGoldberg JoshuaKGoldberg merged commit 43bfd62 into main Aug 22, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the accessibility branch August 22, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Add a "Link" type to UserWrappr options menus 🐛 Bug: Fix HTML to be properly accessible
1 participant