Skip to content

Conversation

@yy462
Copy link
Contributor

@yy462 yy462 commented Feb 21, 2025

Update config paths, and adjust Ray cluster setup

@yy462 yy462 requested review from Ryan-YuanLi and yh-yao February 21, 2025 09:03
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the usage of .bak file, we've already had a eks_cluster_config.yaml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna delete it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just a figure plot, not sure if we're going to include that into examples folder

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I do not think we need to include this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same problem

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gat files shouldn't be merged at this stage

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, I just copied it from another branch, gonna delete them

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure you explain why we need benchmark folder in the document, if it's previous experiments, make sure it's runnable

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put figures script into dev_script folder

@yh-yao yh-yao merged commit 2e96146 into main Mar 7, 2025
2 checks passed
@yh-yao yh-yao deleted the setup-ray-cluster branch September 18, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants