Change groupId to com.falkordb for Maven Central publishing #14
Conversation
This enables publishing to Maven Central under the FalkorDB namespace, which we have permissions for. The org.springframework.data namespace requires Spring project authorization.
WalkthroughThe Maven project's groupId coordinate has been updated from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pom.xml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Tests (Java 17)
- GitHub Check: Tests (Java 21)
| </parent> | ||
|
|
||
| <groupId>org.springframework.data</groupId> | ||
| <groupId>com.falkordb</groupId> |
There was a problem hiding this comment.
🧩 Analysis chain
✓ Correct groupId change for Maven Central publishing.
The Maven groupId has been cleanly updated to com.falkordb to align with the FalkorDB namespace that is approved for Maven Central publishing. The parent groupId (org.springframework.data.build) correctly remains unchanged, as it references an external Spring Data parent POM, not the project's own coordinates.
Since this coordinate change may be referenced in downstream build configurations, CI/CD pipelines, or consumer documentation, verify that no other files in the repository (e.g., build scripts, GitHub Actions workflows, module imports, or README examples) hardcode the old org.springframework.data:spring-data-falkordb coordinates:
🏁 Script executed:
#!/bin/bash
# Search for references to the old groupId coordinates across the repository
rg -i 'org\.springframework\.data.*spring-data-falkordb' --type=xml --type=yaml --type=md --type=txt --type=adoc -nLength of output: 28
---
🏁 Script executed:
```shell
#!/bin/bash
# Search for references to the old groupId coordinates across the repository
# Removed invalid 'adoc' file type
rg -i 'org\.springframework\.data.*spring-data-falkordb' --type=xml --type=yaml --type=md --type=txt -n
Length of output: 296
🏁 Script executed:
#!/bin/bash
# Also search for just the old groupId pattern more broadly
rg 'org\.springframework\.data' -nLength of output: 45472
Update README files to reflect the new Maven groupId.
The pom.xml groupId change to com.falkordb is correct, but documentation files were not updated. README.md and SPRING_DATA_FALKORDB_README.md still reference the old org.springframework.data groupId in dependency examples, which will cause build failures for users:
- README.md (lines 4, 33, 49): Update Maven Central badge URL and dependency snippets to use
com.falkordb:spring-data-falkordb - SPRING_DATA_FALKORDB_README.md (line 20): Update groupId to
com.falkordb
🤖 Prompt for AI Agents
In pom.xml line 28 and across docs: update README.md (lines 4, 33, 49) and
SPRING_DATA_FALKORDB_README.md (line 20) to reflect the new Maven groupId
com.falkordb; change the Maven Central badge URL in README.md to reference
com.falkordb:spring-data-falkordb and update all dependency snippets in both
README files to use groupId com.falkordb and artifactId spring-data-falkordb
(i.e., replace occurrences of org.springframework.data with com.falkordb and
ensure the dependency coordinates match the new pom).
Description
Changes the Maven groupId from
org.springframework.datatocom.falkordbto enable publishing to Maven Central.Changes
org.springframework.datatocom.falkordbWhy
The previous release attempts failed because we don't have authorization to publish under the
org.springframework.datanamespace, which requires Spring project approval.FalkorDB controls the
com.falkordbnamespace on Maven Central, so this change will allow successful publication.Dependency Usage
Users will now include the dependency as:
The package names and Java imports remain unchanged.
Summary by CodeRabbit