Skip to content

Change groupId to com.falkordb for Maven Central publishing #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2025
Merged

Change groupId to com.falkordb for Maven Central publishing #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<version>4.0.0-RC1</version>
</parent>

<groupId>org.springframework.data</groupId>
<groupId>com.falkordb</groupId>
Copy link

@coderabbitai coderabbitai bot Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

✓ Correct groupId change for Maven Central publishing.

The Maven groupId has been cleanly updated to com.falkordb to align with the FalkorDB namespace that is approved for Maven Central publishing. The parent groupId (org.springframework.data.build) correctly remains unchanged, as it references an external Spring Data parent POM, not the project's own coordinates.

Since this coordinate change may be referenced in downstream build configurations, CI/CD pipelines, or consumer documentation, verify that no other files in the repository (e.g., build scripts, GitHub Actions workflows, module imports, or README examples) hardcode the old org.springframework.data:spring-data-falkordb coordinates:

🏁 Script executed:

#!/bin/bash
# Search for references to the old groupId coordinates across the repository
rg -i 'org\.springframework\.data.*spring-data-falkordb' --type=xml --type=yaml --type=md --type=txt --type=adoc -n

Length of output: 28


---

🏁 Script executed:

```shell
#!/bin/bash
# Search for references to the old groupId coordinates across the repository
# Removed invalid 'adoc' file type
rg -i 'org\.springframework\.data.*spring-data-falkordb' --type=xml --type=yaml --type=md --type=txt -n

Length of output: 296

🏁 Script executed:

#!/bin/bash
# Also search for just the old groupId pattern more broadly
rg 'org\.springframework\.data' -n

Length of output: 45472

Update README files to reflect the new Maven groupId.

The pom.xml groupId change to com.falkordb is correct, but documentation files were not updated. README.md and SPRING_DATA_FALKORDB_README.md still reference the old org.springframework.data groupId in dependency examples, which will cause build failures for users:

  • README.md (lines 4, 33, 49): Update Maven Central badge URL and dependency snippets to use com.falkordb:spring-data-falkordb
  • SPRING_DATA_FALKORDB_README.md (line 20): Update groupId to com.falkordb
🤖 Prompt for AI Agents 
In pom.xml line 28 and across docs: update README.md (lines 4, 33, 49) and
SPRING_DATA_FALKORDB_README.md (line 20) to reflect the new Maven groupId
com.falkordb; change the Maven Central badge URL in README.md to reference
com.falkordb:spring-data-falkordb and update all dependency snippets in both
README files to use groupId com.falkordb and artifactId spring-data-falkordb
(i.e., replace occurrences of org.springframework.data with com.falkordb and
ensure the dependency coordinates match the new pom).

<artifactId>spring-data-falkordb</artifactId>
<version>1.0.0-SNAPSHOT</version>

Expand Down