Skip to content

Bugfix: Fixing bug with EnableDefaultWorldGeocode value not being honored in MAUI #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 25, 2025
Merged

Bugfix: Fixing bug with EnableDefaultWorldGeocode value not being honored in MAUI #655

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2339172
Add Loaded event handler to SearchView for initialization
prathameshnarkhede Jun 6, 2025
fe1bb2f
Refactor SearchView event handling logic
prathameshnarkhede Jun 9, 2025
a1bc4f8
Update default value for EnableDefaultWorldGeocoder
prathameshnarkhede Jun 9, 2025
adece8f
Adding extra safety check for Laoded and unlaoded event
prathameshnarkhede Jun 11, 2025
a77c84f
Refactor loading tasks and lifecycle management
prathameshnarkhede Jun 13, 2025
ca64652
- Enhanced LocatorSearchSource and simplify loading tasks
prathameshnarkhede Jun 18, 2025
1739940
Adjusting Spacing
prathameshnarkhede Jun 18, 2025
6f1ec8c
- Introduced `OnPropertyChanged` method.
prathameshnarkhede Jun 18, 2025
73d6998
Added a new entry in `Resources.resx` for the default display name "L…
prathameshnarkhede Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Toolkit/Toolkit.UI.Controls/SearchView/SearchView.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,7 +615,7 @@ public string? RepeatSearchButtonText
/// Identifies the <see cref="EnableDefaultWorldGeocoder"/> dependency property.
/// </summary>
public static readonly DependencyProperty EnableDefaultWorldGeocoderProperty =
DependencyProperty.Register(nameof(EnableDefaultWorldGeocoder), typeof(bool), typeof(SearchView), new PropertyMetadata(false, OnEnableDefualtWorldGeocoderPropertyChanged));
DependencyProperty.Register(nameof(EnableDefaultWorldGeocoder), typeof(bool), typeof(SearchView), new PropertyMetadata(true, OnEnableDefualtWorldGeocoderPropertyChanged));

/// <summary>
/// Identifies the <see cref="EnableRepeatSearchHereButton"/> dependency proeprty.
Expand Down
1 change: 0 additions & 1 deletion src/Toolkit/Toolkit.WPF/UI/Controls/SearchView/SearchView.Theme.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,6 +569,5 @@
<Setter Property="VerticalAlignment" Value="Top" />
<Setter Property="Width" Value="256" />
<Setter Property="Margin" Value="4" />
<Setter Property="EnableDefaultWorldGeocoder" Value="True" />
</Style>
</ResourceDictionary>
1 change: 0 additions & 1 deletion src/Toolkit/Toolkit.WinUI/UI/Controls/SearchView/SearchView.Theme.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,6 +653,5 @@
<Setter Property="VerticalAlignment" Value="Top" />
<Setter Property="Width" Value="256" />
<Setter Property="Margin" Value="4" />
<Setter Property="EnableDefaultWorldGeocoder" Value="True" />
</Style>
</ResourceDictionary>
Loading