Bugfix: Fixing bug with EnableDefaultWorldGeocode value not being honored in MAUI #655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotMorten
reviewed
Jun 9, 2025
Removed the unsubscribe line from `SearchView_Loaded`. Added a check in `HandleViewpointChanged` to ensure the view is loaded before executing logic.
prathameshnarkhede
changed the title
I tested the behavior with WinUI, WPF and and UWP and seems that it is working as expected. It is only bug with MAUI. |
dotMorten
reviewed
Jun 10, 2025
I thought you said it was because WinUI/WPF/UWP test app was using a view model in the sample that avoided hitting the problem, not that it wasn't a problem? |
I was mentioning about this. |
mstefarov
approved these changes
Jun 10, 2025
dotMorten
reviewed
Jun 11, 2025
- Changed `_loadTask` in `LocatorSearchSource` to `Lazy<Task>` for lazy initialization. - Modified `WorldGeocoderSearchSource` to use `Lazy<Task>` for `_additionalLoadTask`.
dotMorten
reviewed
Jun 17, 2025
src/Toolkit/Toolkit/UI/Controls/SearchView/LocatorSearchSource.cs
Outdated
Show resolved
Hide resolved
src/Toolkit/Toolkit/UI/Controls/SearchView/LocatorSearchSource.cs
Outdated
Show resolved
Hide resolved
- Updated LocatorSearchSource to implement INotifyPropertyChanged, introducing a new display name management system. - - Removed the _additionalLoadTask from WorldGeocoderSearchSource, simplifying the loading process to rely only on LoadTask.
- Modified logic to ensure `_displayName` is set to an empty string if both `Name` and `Description` are unavailable, preventing potential null states. - Added `ProeprtyChanged` Event for DisplayName When Refresh happens.
dotMorten
approved these changes
Jun 25, 2025
src/Toolkit/Toolkit/UI/Controls/SearchView/LocatorSearchSource.cs
Outdated
Show resolved
Hide resolved
prathameshnarkhede
deleted the
pratham/fix-EnableDefaultWorldGeocode-searchview
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.