Change f_de parametrization to avoid division by log(1) #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eelregit
force-pushed
the
eelregit_f_de_patch
branch
from
4839d45 to
5e0e437
Compare
EiffL
approved these changes
Jan 20, 2022
Member
EiffL
left a comment
EiffL
left a comment
There was a problem hiding this comment.
LGTM thanks Yin! I've also added a test to make sure everything still behaves as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parametrization is changed from
$a^f_old(a)$to$e^f_new(a)$.