Skip to content
This repository was archived by the owner on Aug 24, 2023. It is now read-only.

Conversation

fuxingloh
Copy link
Contributor

@fuxingloh fuxingloh commented Sep 7, 2022

What this PR does / why we need it:

Add internal @defimetachain/typescript for housing and keeping tsconfig.json DRY and public @defimetachain/network for various network configurations for MainNet, TestNet, and other testing purposes.

@defichain-bot defichain-bot added the kind/chore Non feature change label Sep 7, 2022
@fuxingloh fuxingloh force-pushed the fuxingloh/typescript-network branch from 2443b07 to 0f5fd07 Compare September 7, 2022 17:09
@netlify
Copy link

netlify bot commented Sep 7, 2022

Deploy Preview for defimetachain ready!

Name Link
🔨 Latest commit 2443b07
🔍 Latest deploy log https://app.netlify.com/sites/defimetachain/deploys/6318d02c2d2d3c0009124460
😎 Deploy Preview https://deploy-preview-72--defimetachain.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 7, 2022

Deploy Preview for defimetachain ready!

Name Link
🔨 Latest commit bd7cf24
🔍 Latest deploy log https://app.netlify.com/sites/defimetachain/deploys/63199cb2b268930008cce5db
😎 Deploy Preview https://deploy-preview-72--defimetachain.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Sep 7, 2022

Docker image for defich/metachain is ready!

Built with commit 4902ce2

  • docker pull ghcr.io/defich/metachain:4902ce2ee73eb2aa970044042e7e294a1dcb2dbf
  • docker pull ghcr.io/defich/metachain:pr-72

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #72 (bd7cf24) into main (76454d8) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main     #72   +/-   ##
=====================================
  Coverage   3.79%   3.79%           
=====================================
  Files         10      10           
  Lines       1711    1711           
=====================================
  Hits          65      65           
  Misses      1646    1646           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@DieHard073055 DieHard073055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
LGTM!

@fuxingloh fuxingloh merged commit 76e36e6 into main Sep 8, 2022
@fuxingloh fuxingloh deleted the fuxingloh/typescript-network branch September 8, 2022 09:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants