Skip to content

Conversation

@gleocadie
Copy link
Collaborator

@gleocadie gleocadie commented Oct 1, 2025

Summary of changes

Disable crash report filtering by default.

Reason for change

Crashtracker is going to be used by customer. It would be great if they could see crashes caused by their code in the UI.

Implementation details

  • Set default value to "0"
  • Add the datadog_crash:true tag if the callstack is suspicious.

Test coverage

Other details

@gleocadie gleocadie requested a review from a team as a code owner October 1, 2025 12:32
@gleocadie gleocadie force-pushed the gleocadie/enable-crashtracker-for-all-crashes branch from fad81ee to 73bfe35 Compare October 1, 2025 14:26
@gleocadie gleocadie force-pushed the gleocadie/enable-crashtracker-for-all-crashes branch from 73bfe35 to d718fff Compare October 1, 2025 14:44
@datadog-official
Copy link

datadog-official bot commented Oct 1, 2025

⚠️ Tests

⚠️ Warnings

❄️ 1 New flaky test detected

TestIastWeakHashingRequestVulnerabilitiesPerRequest from Datadog.Trace.Security.IntegrationTests.Iast.AspNetCore5IastTestsOneVulnerabilityPerRequestIastEnabled (Datadog) (✨ Fix with BitsAI)
Unable to determine port application is listening on

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 197e2f7 | Docs | Was this helpful? Give us feedback!

@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Oct 1, 2025

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7598) - mean (72ms)  : 71, 74
     .   : milestone, 72,
    master - mean (72ms)  : 71, 73
     .   : milestone, 72,

    section Baseline
    This PR (7598) - mean (69ms)  : 67, 71
     .   : milestone, 69,
    master - mean (69ms)  : 65, 73
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (7598) - mean (1,052ms)  : 1001, 1102
     .   : milestone, 1052,
    master - mean (1,056ms)  : 992, 1120
     .   : milestone, 1056,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7598) - mean (108ms)  : 106, 110
     .   : milestone, 108,
    master - mean (107ms)  : 105, 108
     .   : milestone, 107,

    section Baseline
    This PR (7598) - mean (106ms)  : 104, 109
     .   : milestone, 106,
    master - mean (106ms)  : 103, 109
     .   : milestone, 106,

    section CallTarget+Inlining+NGEN
    This PR (7598) - mean (747ms)  : 725, 770
     .   : milestone, 747,
    master - mean (751ms)  : 724, 779
     .   : milestone, 751,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7598) - mean (102ms)  : 100, 103
     .   : milestone, 102,
    master - mean (107ms)  : 104, 110
     .   : milestone, 107,

    section Baseline
    This PR (7598) - mean (101ms)  : 99, 103
     .   : milestone, 101,
    master - mean (102ms)  : 100, 104
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (7598) - mean (778ms)  : 731, 824
     .   : milestone, 778,
    master - mean (803ms)  : 753, 852
     .   : milestone, 803,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7598) - mean (94ms)  : 92, 95
     .   : milestone, 94,
    master - mean (98ms)  : 96, 100
     .   : milestone, 98,

    section Baseline
    This PR (7598) - mean (93ms)  : 90, 96
     .   : milestone, 93,
    master - mean (98ms)  : 95, 101
     .   : milestone, 98,

    section CallTarget+Inlining+NGEN
    This PR (7598) - mean (661ms)  : 640, 681
     .   : milestone, 661,
    master - mean (675ms)  : 655, 695
     .   : milestone, 675,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7598) - mean (210ms)  : 194, 226
     .   : milestone, 210,
    master - mean (207ms)  : 197, 216
     .   : milestone, 207,

    section Baseline
    This PR (7598) - mean (206ms)  : 193, 220
     .   : milestone, 206,
    master - mean (204ms)  : 195, 213
     .   : milestone, 204,

    section CallTarget+Inlining+NGEN
    This PR (7598) - mean (1,212ms)  : 1148, 1276
     .   : milestone, 1212,
    master - mean (1,217ms)  : 1135, 1299
     .   : milestone, 1217,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7598) - mean (294ms)  : 276, 312
     .   : milestone, 294,
    master - mean (296ms)  : 281, 312
     .   : milestone, 296,

    section Baseline
    This PR (7598) - mean (292ms)  : 276, 308
     .   : milestone, 292,
    master - mean (296ms)  : 278, 314
     .   : milestone, 296,

    section CallTarget+Inlining+NGEN
    This PR (7598) - mean (996ms)  : 953, 1039
     .   : milestone, 996,
    master - mean (979ms)  : 946, 1012
     .   : milestone, 979,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7598) - mean (300ms)  : 281, 319
     .   : milestone, 300,
    master - mean (299ms)  : 283, 314
     .   : milestone, 299,

    section Baseline
    This PR (7598) - mean (301ms)  : 282, 321
     .   : milestone, 301,
    master - mean (298ms)  : 282, 313
     .   : milestone, 298,

    section CallTarget+Inlining+NGEN
    This PR (7598) - mean (1,035ms)  : 982, 1088
     .   : milestone, 1035,
    master - mean (1,022ms)  : 954, 1089
     .   : milestone, 1022,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7598) - mean (288ms)  : 270, 305
     .   : milestone, 288,
    master - mean (286ms)  : 271, 301
     .   : milestone, 286,

    section Baseline
    This PR (7598) - mean (285ms)  : 270, 300
     .   : milestone, 285,
    master - mean (285ms)  : 270, 301
     .   : milestone, 285,

    section CallTarget+Inlining+NGEN
    This PR (7598) - mean (909ms)  : 832, 987
     .   : milestone, 909,
    master - mean (903ms)  : 840, 966
     .   : milestone, 903,

Loading

@gleocadie gleocadie merged commit 7c311a4 into master Oct 2, 2025
153 checks passed
@gleocadie gleocadie deleted the gleocadie/enable-crashtracker-for-all-crashes branch October 2, 2025 09:50
@github-actions github-actions bot added this to the vNext-v3 milestone Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants