[crashtracking] Change Crashtracking filtering default value (#7598)

Author: gleocadie

tracer/src/Datadog.Trace.Tools.dd_dotnet/CreatedumpCommand.cs

@@ -687,7 +687,8 @@ private unsafe void GenerateCrashReport(int pid, int? signal, int? crashThread)
 
         if (!isSuspicious)
         {
-            var filteringEnabled = Environment.GetEnvironmentVariable(EnvironmentFilteringEnabled) ?? string.Empty;
+            // Disable filtering by default.
+            var filteringEnabled = Environment.GetEnvironmentVariable(EnvironmentFilteringEnabled) ?? "0";
 
             if (filteringEnabled == "0"
                 || filteringEnabled.Equals("false", StringComparison.OrdinalIgnoreCase)
@@ -713,7 +714,7 @@ private unsafe void GenerateCrashReport(int pid, int? signal, int? crashThread)
         }
 
         DebugPrint("Setting crash report metadata");
-        _ = SetMetadata(crashReport, _runtime, exception);
+        _ = SetMetadata(crashReport, _runtime, exception, isSuspicious);
 
         try
         {
@@ -809,7 +810,7 @@ private bool SetSignal(ICrashReport crashReport, int signal)
         return true;
     }
 
-    private unsafe bool SetMetadata(ICrashReport crashReport, ClrRuntime runtime, ClrException? exception)
+    private unsafe bool SetMetadata(ICrashReport crashReport, ClrRuntime runtime, ClrException? exception, bool isSuspicious)
     {
         var flavor = runtime.ClrInfo.Flavor switch
         {
@@ -855,6 +856,11 @@ private unsafe bool SetMetadata(ICrashReport crashReport, ClrRuntime runtime, Cl
             tags = [.. tags, ("exception", exception.ToString())];
         }
 
+        if (isSuspicious)
+        {
+            tags = [.. tags, ("crash_datadog", "true")];
+        }
+
         var bag = new List<IntPtr>();
 
         try

tracer/test/Datadog.Trace.Tools.dd_dotnet.ArtifactTests/CreatedumpTests.cs

@@ -480,7 +480,7 @@ bool IsCrashReport(object payload)
     [SkippableTheory]
     [InlineData(true)]
     [InlineData(false)]
-    public async Task IgnoreNonDatadogCrashes(bool mainThread)
+    public async Task OptionallyDoNotReportNonDatadogCrashes(bool mainThread)
     {
         SkipOn.Platform(SkipOn.PlatformValue.MacOs);
         SkipOn.PlatformAndArchitecture(SkipOn.PlatformValue.Windows, SkipOn.ArchitectureValue.X86);
@@ -492,7 +492,7 @@ public async Task IgnoreNonDatadogCrashes(bool mainThread)
         using var helper = await StartConsoleWithArgs(
                                arg,
                                enableProfiler: true,
-                               [LdPreloadConfig, CrashReportConfig(reportFile)]);
+                               [LdPreloadConfig, CrashReportConfig(reportFile), ("DD_CRASHTRACKING_FILTERING_ENABLED", "1")]);
 
         await helper.Task;
 
@@ -507,11 +507,8 @@ public async Task IgnoreNonDatadogCrashes(bool mainThread)
     }
 
     [SkippableFact]
-    public async Task OptionallyReportNonDatadogCrashes()
+    public async Task ReportNonDatadogCrashes()
     {
-        // This test only validates the case where DD_CRASHTRACKING_FILTERING_ENABLED is set to 0
-        // The default case is tested by IgnoreNonDatadogCrashes
-
         SkipOn.Platform(SkipOn.PlatformValue.MacOs);
         SkipOn.PlatformAndArchitecture(SkipOn.PlatformValue.Windows, SkipOn.ArchitectureValue.X86);
 
@@ -532,6 +529,29 @@ public async Task OptionallyReportNonDatadogCrashes()
         File.Exists(reportFile.Path).Should().BeTrue();
     }
 
+    [SkippableFact]
+    public async Task MakeSureNonDatadogCrashesAreReportedByDefault()
+    {
+        SkipOn.Platform(SkipOn.PlatformValue.MacOs);
+        SkipOn.PlatformAndArchitecture(SkipOn.PlatformValue.Windows, SkipOn.ArchitectureValue.X86);
+
+        using var reportFile = new TemporaryFile();
+
+        using var helper = await StartConsoleWithArgs(
+                               "crash",
+                               enableProfiler: true,
+                               [LdPreloadConfig, CrashReportConfig(reportFile)]);
+
+        await helper.Task;
+
+        if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux))
+        {
+            helper.StandardOutput.Should().Contain(CrashReportUnfilteredExpectedOutput);
+        }
+
+        File.Exists(reportFile.Path).Should().BeTrue();
+    }
+
     [SkippableFact]
     public async Task ReportedStacktrace()
     {