Skip to content

Add diagnostics for invalid expressions for forwarded attributes #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Sergio0694 merged 2 commits into from
May 11, 2023
Merged

Add diagnostics for invalid expressions for forwarded attributes #684

Sergio0694 merged 2 commits into from
May 11, 2023

Conversation

@Sergio0694
Copy link
Member

@Sergio0694 Sergio0694 commented May 7, 2023

Closes #683

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit bugfix 🔧 PRs fixing a discovered bug labels May 7, 2023
@Sergio0694 Sergio0694 marked this pull request as draft May 7, 2023 13:25
@Sergio0694 Sergio0694 force-pushed the dev/fix-attribute-expressions branch from 4315699 to 96a6e8f Compare May 7, 2023 18:31
@Sergio0694 Sergio0694 marked this pull request as ready for review May 7, 2023 18:31
@Sergio0694 Sergio0694 requested a review from Arlodotexe May 8, 2023 10:47
@Sergio0694 Sergio0694 force-pushed the dev/fix-attribute-expressions branch 3 times, most recently from 2801329 to a3a6d8f Compare May 10, 2023 14:28
@Sergio0694 Sergio0694 force-pushed the dev/fix-attribute-expressions branch from a3a6d8f to 01f07fe Compare May 10, 2023 14:47
@Sergio0694 Sergio0694 merged commit 6fe5b48 into main May 11, 2023
@delete-merged-branch delete-merged-branch bot deleted the dev/fix-attribute-expressions branch May 11, 2023 11:28
This was referenced Nov 17, 2025
Merged
Closed
@dependabot dependabot bot mentioned this pull request Dec 11, 2025
Open
@dependabot dependabot bot mentioned this pull request Dec 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Arlodotexe Arlodotexe Arlodotexe approved these changes

Assignees

No one assigned

Labels

bugfix 🔧 PRs fixing a discovered bug mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit

Projects

No open projects
8.2.1
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Forwarded attributes can crash generator when accessing invalid members

2 participants

@Sergio0694 @Arlodotexe