Skip to content

Forwarded attributes can crash generator when accessing invalid members #683

@Sergio0694

Description

@Sergio0694

Describe the bug

The forwarded attribute logic (for both observable properties and relay commands) can crash the generator in some invalid scenarios. We should instead emit a proper diagnostic and gracefully skip the current attribute, rather than crashing the generator.

Steps to reproduce

public partial class Foo : ObservableObject
{
    [ObservableProperty]
    [property: Test(TestAttribute.M)]
    private int number;
}

public class TestAttribute : Attribute
{
    public static string M => "";
}

Expected behavior

This should skip the attribute and generate a diagnostic.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug 🐛An unexpected issue that highlights incorrect behaviormvvm-toolkit 🧰Issues/PRs for the MVVM Toolkit

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions