Skip to content

Conversation

@oising
Copy link
Contributor

@oising oising commented May 31, 2025

Closes #707

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • New integration
    • Docs are written (README.md)
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

@oising oising marked this pull request as ready for review May 31, 2025 00:29
Copilot AI review requested due to automatic review settings May 31, 2025 00:29

This comment was marked as outdated.

Copy link
Member

@aaronpowell aaronpowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start, there's some code changes I've got in there.

Can you also look at the unit tests as well as the integration tests, to match the test design of other integrations.

Also, it doesn't appear that the projects are in the slnx so they'll need to be added to ensure they are built.

Lastly, the PowerShell expects the Azure CLI to be installed, maybe we should have simpler scripts without those dependencies, otherwise the devcontainer + CI will need to be updated to ensure that the Azure CLI is installed.

oising and others added 3 commits June 3, 2025 09:48
…icationBuilderExtensions.cs

Co-authored-by: Aaron Powell <[email protected]>
…acePoolResourceBuilderExtensions.cs

Co-authored-by: Aaron Powell <[email protected]>
…icationBuilderExtensions.cs

Co-authored-by: Aaron Powell <[email protected]>
@github-actions github-actions bot added the Stale label Jun 9, 2025
@oising oising requested review from aaronpowell and Copilot June 10, 2025 21:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds PowerShell scripting support to the Aspire AppHost by introducing new PowerShell resource types, runspace pool management, and corresponding integration tests and documentation.

  • Adds a new PowerShell scripting project and supporting resource builders/extensions.
  • Introduces integration tests to validate script execution and host functionality.
  • Updates solution and project files to integrate with the existing Aspire framework.

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.

File Description
tests/CommunityToolkit.Aspire.Hosting.PowerShell.Tests/* New tests for PowerShell resource execution.
src/CommunityToolkit.Aspire.Hosting.PowerShell/* New implementation of PowerShell scripting and runspace pool resources.
examples/powershell/* Example app host demonstrating usage of the new PowerShell scripting support.
Directory.Packages.props Updated package references to support PowerShell SDK.

@aaronpowell aaronpowell removed the Stale label Jun 10, 2025
@oising oising requested a review from aaronpowell June 11, 2025 18:08
Copy link
Contributor Author

@oising oising left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aaronpowell aaronpowell merged commit faab258 into CommunityToolkit:main Jun 17, 2025
96 checks passed
@aaronpowell aaronpowell added this to the 9.6 milestone Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for powershell scripting in the AppHost

3 participants