Support ignoring file deletions #76
Conversation
johnlk
force-pushed
the
john/ignore-file-deletions
branch
from
5b02d25 to
e022e7b
Compare
|
cc: @OnkarRuikar |
JavierCane
left a comment
JavierCane
left a comment
There was a problem hiding this comment.
Hi @johnlk, gooooooood work 🎉 🙌
-
I have taken the freedom to commit some
README.mdchanges in the branch instead of making them as a PR comment suggestions because GitHub does not allow me to do so due to implying some non-modified lines 😬Feel free to discuss any concern regarding the changes 🙏😇
-
Regarding the inspiration on #61, I completely understand that, given the modifications in the project since that PR it is easier to implement it in a new PR (my fault on not reviewing them on time). However, I would propose to add @rwyland
as the merge commit co-author in order to give him credit for the contribution 😊Taking a look to his contributions to other public repositories, it would be just by adding the following to the merge commit:
Co-authored-by: Rob W <[email protected]>
Tweak action.yml
Co-authored-by: Onkar Ruikar <[email protected]>
Co-authored-by: Onkar Ruikar <[email protected]>
johnlk
force-pushed
the
john/ignore-file-deletions
branch
from
044d140 to
bcadc34
Compare
…he most related arguments to make it easier to read Improve the existing contribution guide (#74) * Improve the existing contribution guide * reorder the contribution steps to push testing up Co-authored-by: Javier Ferrer González <[email protected]> * tweak contribution process opener copy Co-authored-by: Javier Ferrer González <[email protected]> --------- Co-authored-by: Javier Ferrer González <[email protected]> Put back accidental deletion
johnlk
force-pushed
the
john/ignore-file-deletions
branch
from
bcadc34 to
a0cfd49
Compare
What type of PR is this? (check all applicable)
Description
This change supports ignoring files which are wholly deleted. This seems to be a common ask. The new config variable is called
ignore_file_deletionsand relies on the files API to determine the status of a file.This change was inspired by #61 , but with updated patterns and tests.
How to test
I added unit tests for the new code paths to ensure everything is behaving as expected.
Link to issues addressed