Improve the existing contribution guide #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnlk
requested review from
JavierCane and
rgomezcasas
and removed request for
rgomezcasas
JavierCane
approved these changes
May 14, 2024
Member
JavierCane
left a comment
JavierCane
left a comment
There was a problem hiding this comment.
Just 2 non-blocking suggestions 😊
Co-authored-by: Javier Ferrer González <[email protected]>
Co-authored-by: Javier Ferrer González <[email protected]>
johnlk
added a commit
that referenced
this pull request
May 14, 2024
* Improve the existing contribution guide * reorder the contribution steps to push testing up Co-authored-by: Javier Ferrer González <[email protected]> * tweak contribution process opener copy Co-authored-by: Javier Ferrer González <[email protected]> --------- Co-authored-by: Javier Ferrer González <[email protected]>
johnlk
pushed a commit
that referenced
this pull request
May 14, 2024
…he most related arguments to make it easier to read Improve the existing contribution guide (#74) * Improve the existing contribution guide * reorder the contribution steps to push testing up Co-authored-by: Javier Ferrer González <[email protected]> * tweak contribution process opener copy Co-authored-by: Javier Ferrer González <[email protected]> --------- Co-authored-by: Javier Ferrer González <[email protected]>
johnlk
pushed a commit
that referenced
this pull request
May 14, 2024
…he most related arguments to make it easier to read Improve the existing contribution guide (#74) * Improve the existing contribution guide * reorder the contribution steps to push testing up Co-authored-by: Javier Ferrer González <[email protected]> * tweak contribution process opener copy Co-authored-by: Javier Ferrer González <[email protected]> --------- Co-authored-by: Javier Ferrer González <[email protected]> Put back accidental deletion
johnlk
added a commit
that referenced
this pull request
May 14, 2024
* Support ignoring file deletions Tweak action.yml * Tweak the readme description Co-authored-by: Onkar Ruikar <[email protected]> * tweak removed file check to include line_deletion var Co-authored-by: Onkar Ruikar <[email protected]> * docs: unify the "Basic concepts or assumptions" readme section into the most related arguments to make it easier to read Improve the existing contribution guide (#74) * Improve the existing contribution guide * reorder the contribution steps to push testing up Co-authored-by: Javier Ferrer González <[email protected]> * tweak contribution process opener copy Co-authored-by: Javier Ferrer González <[email protected]> --------- Co-authored-by: Javier Ferrer González <[email protected]> Put back accidental deletion --------- Co-authored-by: Onkar Ruikar <[email protected]> Co-authored-by: Javier Ferrer González <[email protected]> Co-authored-by: Rob W <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
We didn't really have a contribution guide, so I'm adding one based on issue #68.
Notes to Reviewer
N/A
How to test
N/A
Link to issues addressed
N/A