Skip to content

Fixing padding around icons #16674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 5, 2025
Merged

Fixing padding around icons #16674

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bfa1c2c
Seems crazy, but I swear, the icons have a slight amount of padding o…
mike12345567 Aug 5, 2025
12bbe83
Merge branch 'master' into fix/slight-icon-padding
mike12345567 Aug 5, 2025
cde9401
REM sizing was leading to fractional font-sizes which left a little b…
mike12345567 Aug 5, 2025
c5d23e5
Merge branch 'fix/slight-icon-padding' of github.com:Budibase/budibas…
mike12345567 Aug 5, 2025
c3a1251
Adding a little nav-item gap, separate the user avatar icon.
mike12345567 Aug 5, 2025
5768919
Switching from REM for icon sizing to px to avoid fractions.
mike12345567 Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/bbui/src/ActionButton/ActionButton.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
{#if icon}
<Icon
name={icon}
size="M"
{size}
color={`var(--spectrum-global-color-gray-${$$slots.default ? 600 : 700})`}
/>
{/if}
Expand Down
14 changes: 7 additions & 7 deletions packages/bbui/src/Icon/InnerIcon.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@
export let weight: "regular" | "bold" | "fill" = "regular"

const sizeMap = {
XS: "0.75rem",
S: "1rem",
M: "1.25rem",
L: "1.5rem",
XL: "2rem",
XXL: "2.5rem",
XXXL: "5rem",
XS: "round(0.75rem, 1px)",
S: "round(1rem, 1px)",
M: "round(1.25rem, 1px)",
L: "round(1.5rem, 1px)",
XL: "round(2rem, 1px)",
XXL: "round(2.5rem, 1px)",
XXXL: "round(5rem, 1px)",
}

$: phosphorIconName = getPhosphorIcon(name)
Expand Down
1 change: 1 addition & 0 deletions packages/builder/src/components/common/NavItem.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,7 @@
align-items: center;
overflow: hidden;
pointer-events: none;
gap: var(--spacing-s);
}
.nav-item-body span {
white-space: nowrap;
Expand Down
11 changes: 8 additions & 3 deletions packages/builder/src/components/integration/QueryViewer.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
Body,
Divider,
Button,
ActionButton,
} from "@budibase/bbui"
import { capitalise } from "@/helpers"
import AccessLevelSelect from "./AccessLevelSelect.svelte"
Expand Down Expand Up @@ -172,10 +173,14 @@
</div>
<div class="controls">
<ConnectedQueryScreens sourceId={query._id} />
<Button disabled={loading} on:click={runQuery} overBackground>
<Icon size="S" name="play" />
Run query</Button
<ActionButton
icon="play"
disabled={loading}
on:click={runQuery}
overBackground
>
Run query
</ActionButton>
<div class="tooltip" title="Run your query to enable saving">
<Button
on:click={async () => {
Expand Down
Loading