Fixing padding around icons #16674
Merged
Fixing padding around icons #16674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the bottom, making them look slightly wrong everywhere, adding a little bit of padding at the top to account for this.
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
…it of odd padding, rounding to the closest pixel.
…e into fix/slight-icon-padding
melohagan
approved these changes
Aug 5, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EDIT: Solution found - REM sizing was leading to fractional font-sizes which left a little bit of odd padding, rounding to the closest pixel.
Icons have slightly odd padding - I'm trying to work out why.
Before:
After:
Check out the preview button and the icons along the left nav to see this in action.