Skip to content

Update Swift Package paths #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 23, 2025
Merged

Update Swift Package paths #179

merged 4 commits into from
May 23, 2025

Conversation

@rudrankriyam
Copy link
Contributor

@rudrankriyam rudrankriyam commented May 22, 2025 •
edited
Loading

Context

This PR addresses several build issues in the Swift package configuration. Fixes #134

Description

  • Fixed the path to ESpeakNG.xcframework to point to the correct location
  • Updated the main target's path to reflect the actual project structure
  • Corrected the test target's path to point to the right test directory
  • Added resources in the Package.swift file

And finally, move the Package.swift to the root for everyone to use it! 🎉

@rudrankriyam rudrankriyam mentioned this pull request May 22, 2025
Closed
lucasnewman
lucasnewman approved these changes May 22, 2025
View reviewed changes
Copy link
Collaborator

@lucasnewman lucasnewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Blaizzy
Blaizzy approved these changes May 23, 2025
View reviewed changes
Copy link
Owner

@Blaizzy Blaizzy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well!

@Blaizzy Blaizzy merged commit 2995af3 into Blaizzy:main May 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Blaizzy Blaizzy Blaizzy approved these changes

@lucasnewman lucasnewman lucasnewman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Package MLX Swift Audio

3 participants

@rudrankriyam @Blaizzy @lucasnewman