Skip to content

ASD-1253 - Remove mixed type references in function signatures (PHP 7 #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaybeckr merged 1 commit into from
May 7, 2025
Merged

ASD-1253 - Remove mixed type references in function signatures (PHP 7 #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Helper/SubscriptionHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ function ($subscription) use ($publicHash) {
* @param mixed $value
Copy link

@jaybeckr jaybeckr May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove this mixed as well?

Copy link
Author

@sgabhart22 sgabhart22 May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, I thought about that... but there are about 60 type hints like this for mixed parameters in docblocks. Doesn't seem to blow anything up with PHP 7, but might be less confusing if they were removed?

Copy link

@jaybeckr jaybeckr May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, yeah lets just leave it alone then

* @return Filter
*/
private function buildFilter(string $field, mixed $value)
private function buildFilter(string $field, $value)
{
return $this->filterBuilder
->setField($field)
Expand Down
2 changes: 1 addition & 1 deletion Helper/Transaction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ public function getIncomplete()
* @param mixed $transactionId
* @return void
*/
public function closeTransaction(mixed $transactionId)
public function closeTransaction($transactionId)
{
$transaction = $this->transactionRepository->get($transactionId);
$transaction->setIsClosed(true);
Expand Down
2 changes: 1 addition & 1 deletion Model/CheckoutSessionManagement.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1365,7 +1365,7 @@ private function closeChargePermission($amazonSessionId, OrderInterface $order,
* @param mixed $orderId
* @return void
*/
public function setOrderPendingPaymentReview(mixed $orderId)
public function setOrderPendingPaymentReview($orderId)
{
try {
if (!$orderId) {
Expand Down