ASD-1253 - Remove mixed type references in function signatures (PHP 7 #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaybeckr
reviewed
May 6, 2025
| * Build a filter for subscription searches | ||
| * | ||
| * @param string $field | ||
| * @param mixed $value |
Author
There was a problem hiding this comment.
Maybe, I thought about that... but there are about 60 type hints like this for mixed parameters in docblocks. Doesn't seem to blow anything up with PHP 7, but might be less confusing if they were removed?
There was a problem hiding this comment.
ah, yeah lets just leave it alone then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compatibility)
Fixes # .
Additional details about this PR