Skip to content

Delete unused components in shared-ui #16872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025

Conversation

georginahalpern
Copy link
Contributor

Found some components that are not referenced when auditing our tools for UI overhaul (plus deleting a file I accidentally added twice in last PR)

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 10, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 10, 2025

@georginahalpern georginahalpern enabled auto-merge (squash) July 10, 2025 23:25
@bjsplat
Copy link
Collaborator

bjsplat commented Jul 10, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16872/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 10, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16872/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16872/merge/?snapshot=refs/pull/16872/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 10, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 10, 2025

@georginahalpern georginahalpern merged commit dd78704 into BabylonJS:master Jul 11, 2025
20 checks passed
@georginahalpern georginahalpern deleted the removeComponents branch July 11, 2025 00:58
VicenteCartas pushed a commit to VicenteCartas/Babylon.js that referenced this pull request Aug 7, 2025
Found some components that are not referenced when auditing our tools
for UI overhaul (plus deleting a file I accidentally added twice in last
PR)

Co-authored-by: Georgina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants