Dependencies: weekly update #6248
Conversation
github-actions
bot
added
the
component: third party
|
I think this needs AMReX-Codes/pyamrex#484 first. |
|
Here we got the checksums updates that @WeiqunZhang had warned about, supposedly related to AMReX-Codes/amrex#4658 and its relatives (AMReX-Codes/amrex#4700 and AMReX-Codes/pyamrex#484). If I find a moment I would like to open a separate PR where I add a feature to output also the maximum relative error for each checksum test that fails, at the end of the output we already have, so it's easier to have an estimate of that. |
|
|
I implemented this small change in #6252. |
This PR adds a print of the maximum relative error when checksums fail, which I think is quite useful when they fail for many "keys" and/or many tests (e.g., #5955, #6248) - the maximum relative error gives a glimpse of how good or bad things are. This is an example of the new output, with the extra line printing the maximum relative error: ``` ... ERROR: Benchmark and output file checksum have different value for key [lev=0,Ex] Benchmark: [lev=0,Ex] 9.408402900367834e+05 Test file: [lev=0,Ex] 9.409402900367834e+05 Absolute error: 1.00e+02 Relative error: 1.06e-04 ERROR: Benchmark and output file checksum have different value for key [lev=0,Ez] Benchmark: [lev=0,Ez] 6.654423300420902e+05 Test file: [lev=0,Ez] 6.754423300420902e+05 Absolute error: 1.00e+04 Relative error: 1.50e-02 ERROR: Benchmark and output file checksum have different value for key [lev=0,jx] Benchmark: [lev=0,jx] 9.956269465957083e+03 Test file: [lev=0,jx] 9.956269365957083e+03 Absolute error: 1.00e-04 Relative error: 1.00e-08 Maximum relative error: 1.50e-02 New checksums file test_2d_larmor.json: ... ``` Feel free to close the PR without merging if you think this is not useful.
Automated via .github/workflows/weekly_update.yml.