Update sum_boundary #484
Merged
Update sum_boundary #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeiqunZhang
force-pushed
the
update_sum_boundary
branch
2 times, most recently
from
c0c1eb6 to
145c430
Compare
WeiqunZhang
force-pushed
the
update_sum_boundary
branch
from
145c430 to
191ab26
Compare
Member
Author
|
This is ready now. |
Member
|
A few CI checks did not run because the Ubuntu/CUDA one failed. Do you know how to fix it? |
Member
Author
|
I cannot reproduce it locally. It might be that I am using different versions of the compilers. |
Member
Author
|
AMReX-Codes/amrex#4700 should fix it. |
Member
Author
|
I think the fix does work. The HIP CI that is still using the old version is failing for the same reason as the CUDA one, which is passing now. |
Member
|
Thanks, @WeiqunZhang! What about the CI check labeled apps / pyamrex that fails in AMReX-Codes/amrex#4700? Is that a new unrelated issue? |
Member
Author
|
The CI in amrex uses the development branch of pyamrex, not this PR branch. So it is expected to fail. |
EZoni
approved these changes
Oct 7, 2025
EZoni
added a commit
to BLAST-WarpX/warpx
that referenced
this pull request
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should wait for AMReX-Codes/amrex#4658.