Skip to content

Conversation

JoshLozensky
Copy link
Contributor

@JoshLozensky JoshLozensky commented Apr 1, 2025

This PR was already approved once, it had to be reverted due to errors caused in another library's tests that were blocking a release. These errors stemmed from the other library's test infra implementation, not any issues with the lock functionality. The other library's tests have been fixed so it is safe to merge this again.

Testing for the changes in this PR is in another PR here. I'm not combining the two as this one was already approved once while that one is still under review.

Here is the originally approved PR

@JoshLozensky JoshLozensky requested a review from a team as a code owner April 1, 2025 01:18
Copy link

github-actions bot commented Apr 1, 2025

Summary

Summary
Generated on: 4/1/2025 - 1:31:56 AM
Coverage date: 4/1/2025 - 1:21:50 AM - 4/1/2025 - 1:31:31 AM
Parser: MultiReport (60x Cobertura)
Assemblies: 1
Classes: 7
Files: 2
Line coverage: 80.3% (620 of 772)
Covered lines: 620
Uncovered lines: 152
Coverable lines: 772
Total lines: 483
Branch coverage: 67.8% (228 of 336)
Covered branches: 228
Total branches: 336
Method coverage: Feature is only available for sponsors

Coverage

Microsoft.IdentityModel.JsonWebTokens - 80.3%
Name Line Branch
Microsoft.IdentityModel.JsonWebTokens 80.3% 67.8%
Microsoft.IdentityModel.JsonWebTokens.JwtTokenUtilities 100%
System.Text.RegularExpressions.Generated 80.3% 67.8%
System.Text.RegularExpressions.Generated 80.3% 67.8%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA
DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJweRegex_1
79.2% 68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA
DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJwsRegex_0
81.4% 67.6%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3
CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJweRegex_1
79.2% 68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3
CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJwsRegex_0
81.4% 67.6%

@JoshLozensky JoshLozensky merged commit bc84916 into dev Apr 2, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants