Add concurrency tests for locks #3185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

JoshLozensky merged 5 commits into dev from lozensky/AddConcurrencyTests

Apr 3, 2025

Contributor

JoshLozensky commented Mar 21, 2025 •

edited

Loading

There were not thread-safety tests for the places we have locks, this adds some. Addresses #3178

JoshLozensky requested a review from a team as a code owner

March 21, 2025 00:34

keegan-caruso reviewed

View reviewed changes

test/Microsoft.IdentityModel.JsonWebTokens.Tests/JsonClaimSetTests.cs Outdated Show resolved Hide resolved

keegan-caruso reviewed

View reviewed changes

test/Microsoft.IdentityModel.JsonWebTokens.Tests/JsonClaimSetTests.cs Outdated Show resolved Hide resolved

keegan-caruso reviewed

View reviewed changes

test/Microsoft.IdentityModel.Tokens.Tests/SecurityKeyTests.cs Outdated Show resolved Hide resolved

keegan-caruso reviewed

View reviewed changes

test/Microsoft.IdentityModel.JsonWebTokens.Tests/JsonClaimSetTests.cs Outdated Show resolved Hide resolved

keegan-caruso reviewed

View reviewed changes

test/Microsoft.IdentityModel.Tokens.Tests/SecurityKeyTests.cs Outdated Show resolved Hide resolved

keegan-caruso reviewed

View reviewed changes

test/Microsoft.IdentityModel.JsonWebTokens.Tests/JsonClaimSetTests.cs Outdated Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

This comment was marked as outdated.

Sign in to view

JoshLozensky added 2 commits

March 24, 2025 13:41


          Add tests

9eb0369


          Change to use Parallel.Invoke and Barrier for tests

e4c697e

JoshLozensky force-pushed the lozensky/AddConcurrencyTests branch from 42f634c to e4c697e Compare

March 24, 2025 20:43

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

kllysng reviewed

View reviewed changes

src/Microsoft.IdentityModel.LoggingExtensions/Microsoft.IdentityModel.LoggingExtensions.csproj Show resolved Hide resolved

keegan-caruso reviewed

View reviewed changes

test/Microsoft.IdentityModel.JsonWebTokens.Tests/JsonClaimSetTests.cs Outdated Show resolved Hide resolved

JoshLozensky mentioned this pull request

Lozensky/gotta change the locks #3189

Merged


          changed tests to use Task per PR feedback

e05357a

This comment was marked as outdated.

Sign in to view

JoshLozensky mentioned this pull request

Need to change the locks #3171

Merged

RojaEnnam reviewed

View reviewed changes

test/Microsoft.IdentityModel.Tokens.Tests/TokenValidationResultTests.cs Outdated Show resolved Hide resolved


          removing extraneous code

d2a14f9

This comment was marked as outdated.

Sign in to view

keegan-caruso approved these changes

View reviewed changes


          Merge branch 'dev' into lozensky/AddConcurrencyTests

4d658a1

github-actions bot commented Apr 2, 2025

Summary

Summary


Generated on:	4/2/2025 - 8:32:11 PM
Coverage date:	4/2/2025 - 8:21:25 PM - 4/2/2025 - 8:31:45 PM
Parser:	MultiReport (60x Cobertura)
Assemblies:	1
Classes:	7
Files:	2
Line coverage:	80.3% (620 of 772)
Covered lines:	620
Uncovered lines:	152
Coverable lines:	772
Total lines:	483
Branch coverage:	67.8% (228 of 336)
Covered branches:	228
Total branches:	336
Method coverage:	Feature is only available for sponsors

Coverage

Microsoft.IdentityModel.JsonWebTokens - 80.3%

Name	Line	Branch
Microsoft.IdentityModel.JsonWebTokens	80.3%	67.8%
Microsoft.IdentityModel.JsonWebTokens.JwtTokenUtilities	100%
System.Text.RegularExpressions.Generated	80.3%	67.8%
System.Text.RegularExpressions.Generated	80.3%	67.8%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJweRegex_1	79.2%	68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJwsRegex_0	81.4%	67.6%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3 CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJweRegex_1	79.2%	68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3 CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJwsRegex_0	81.4%	67.6%

RojaEnnam approved these changes

View reviewed changes

JoshLozensky merged commit c939be3 into dev

6 checks passed

JoshLozensky deleted the lozensky/AddConcurrencyTests branch

April 3, 2025 18:13

dependabot bot mentioned this pull request

Bump Microsoft.IdentityModel.JsonWebTokens to 8.13.0 devlooped/CloudStorageAccount#222

Closed

This was referenced Aug 15, 2025

Bump Microsoft.IdentityModel.Abstractions from 8.0.1 to 8.13.1 statisticssweden/PxWeb#702

Closed

Bump Microsoft.IdentityModel.JsonWebTokens from 8.0.1 to 8.13.1 statisticssweden/PxWeb#703

Closed

Bump Microsoft.IdentityModel.Logging from 8.0.1 to 8.13.1 statisticssweden/PxWeb#704

Closed

Bump Microsoft.IdentityModel.Protocols from 8.0.1 to 8.13.1 statisticssweden/PxWeb#705

Closed

Bump Microsoft.IdentityModel.Protocols.OpenIdConnect from 8.0.1 to 8.13.1 statisticssweden/PxWeb#706

Closed

Bump Microsoft.IdentityModel.Tokens from 8.0.1 to 8.13.1 statisticssweden/PxWeb#707

Closed

Bump the identity group with 1 update devlooped/CloudStorageAccount#228

Closed

Bump System.IdentityModel.Tokens.Jwt from 8.3.0 to 8.13.1 drakon64/Ktisis#39

Closed

Bump the identity group with 1 update devlooped/Mvp.Xml#114

Closed

deps: Bump the auth-ecosystem group with 2 updates aioutlet/payment-service#3

Open

Bump Microsoft.IdentityModel.Protocols.OpenIdConnect from 8.0.1 to 8.14.0 statisticssweden/PxWeb#709

Open

Bump Microsoft.IdentityModel.JsonWebTokens from 8.0.1 to 8.14.0 statisticssweden/PxWeb#711

Open

Bump Microsoft.IdentityModel.Logging from 8.0.1 to 8.14.0 statisticssweden/PxWeb#712

Open

Bump Microsoft.IdentityModel.Protocols from 8.0.1 to 8.14.0 statisticssweden/PxWeb#713

Open

Bump Microsoft.IdentityModel.Tokens from 8.0.1 to 8.14.0 statisticssweden/PxWeb#714

Open

Bump Microsoft.IdentityModel.Abstractions from 8.0.1 to 8.14.0 statisticssweden/PxWeb#715

Open

Bump System.IdentityModel.Tokens.Jwt from 8.3.0 to 8.14.0 drakon64/Ktisis#40

Open

Bump Microsoft.IdentityModel.JsonWebTokens to 8.14.0 devlooped/CloudStorageAccount#229

Closed

Bump Microsoft.IdentityModel.Tokens from 6.34.0 to 8.14.0 The404Studios/Kenshi-Online#17

Closed

Bump Microsoft.IdentityModel.Tokens and System.IdentityModel.Tokens.Jwt The404Studios/Kenshi-Online#18

Merged

Bump Microsoft.IdentityModel.Tokens from 6.34.0 to 8.14.0 The404Studios/Kenshi-Online#19

Merged

Bump System.IdentityModel.Tokens.Jwt from 8.4.0 to 8.14.0 Hochfrequenz/AhbichtClient.net#65

Open

Bump Microsoft.IdentityModel.JsonWebTokens to 8.14.0 devlooped/Mvp.Xml#115

Closed

Bump the identity group with 1 update devlooped/Mvp.Xml#116

Open

Bump System.IdentityModel.Tokens.Jwt from 8.0.1 to 8.14.0 statisticssweden/PxWeb#727

Open

Bump System.IdentityModel.Tokens.Jwt from 7.3.1 to 8.14.0 CleveritDemo/AzureSREAgent#1

Open

Bump the identity group with 1 update devlooped/CloudStorageAccount#230

Open

Bump System.IdentityModel.Tokens.Jwt from 8.2.1 to 8.14.0 LtiLibrary/LtiAdvantage#182

Closed

This was referenced Aug 22, 2025

Bump Azure.Identity and 3 others Ed-Fi-Alliance-OSS/Data-Management-Service#690

Closed

Bump Azure.Identity and 2 others Ed-Fi-Alliance-OSS/Data-Management-Service#694

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet