Skip to content

Conversation

aavasthy
Copy link
Contributor

@aavasthy aavasthy commented Aug 27, 2025

Pull Request Template

Description

This is a hotfix for including :

This bumps the SDK GA version from 3.53.0 to 3.53.1 and preview version from 3.54.0-preview.0 to 3.54.0-preview.1 It is a patch upgrade to the previous release.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Closing issues

To automatically close an issue: closes #IssueNumber

aavasthy and others added 3 commits August 27, 2025 10:16
#5364)

# Pull Request Template

## Description

It's a follow up for this PR
#5252, which
introduces the ability to override AAD scope value. As part of the
current PR, use overridden scope if its provided and there is no
fallback for this.
If no overridden scope is provided then use account scope and if this
fails with exception
[AADSTS500011](https://learn.microsoft.com/en-us/entra/identity-platform/reference-error-codes)
then fallback to this scope "https://cosmos.azure.com/.default". Each
scope continues to go through existing validations.
## Type of change

Please delete options that are not relevant.

- [X] New feature (non-breaking change which adds functionality)


## Closing issues

To automatically close an issue: closes #IssueNumber
kundadebdatta
kundadebdatta previously approved these changes Aug 27, 2025
FabianMeiswinkel and others added 2 commits August 27, 2025 13:03
…e and InvalidOperationException (#5361)

# Pull Request Template

## Description

When cross-region hedging is enabled in the Azure Cosmos DB .NET SDK,
users experience high CPU usage or InvalidOperationExceptions ue to
thread safety issues when accessing dictionaries in the Trace class. The
issue occurs in the AddOrUpdateDatum method where multiple parallel
threads attempt to update the same dictionary without proper
synchronization.

### Design considerations
The approach chosen is motivated by:
- the need to maintain the order of TraceDatum nodes - the laternative
of switching to a ConcurrentDictionary instead off keeping Dictonary and
making it thread-safe would result in reordering of trace datum nodes
- non-functional optimization for the normal request flow where
materialization o fthe diagnostics only strats after request processing
completes (and no more new trace datum nodes/children) are added to a
trace. There are a few edge cases like cross regional retries and
timeouts where trace datum nodes could still be added after starting to
materialize the trace. The current design marks the begin of
materialization and would afterwards create new snapshots for every
mutation. This allows making sure that Trace.Data or Trace.Children
oeprate on a snapshot that is immutable (thread-safe) - but between
multiple calls to ITrace.Data/Children different isntances could be
returned - and they might have different content.

## Type of change

Please delete options that are not relevant.

- [x] Bug fix (non-breaking change which fixes an issue)
- [] New feature (non-breaking change which adds functionality)
- [] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [] This change requires a documentation update

## Closing issues

To automatically close an issue: closes #IssueNumber

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: kirankumarkolli <[email protected]>
Co-authored-by: Kiran Kumar Kolli <[email protected]>
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thx

@aavasthy aavasthy added the auto-merge Enables automation to merge PRs label Aug 27, 2025
@aavasthy aavasthy added DO NOT MERGE auto-merge Enables automation to merge PRs and removed auto-merge Enables automation to merge PRs DO NOT MERGE labels Aug 28, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) August 28, 2025 00:18
@kushagraThapar kushagraThapar enabled auto-merge (squash) August 28, 2025 00:35
@kushagraThapar kushagraThapar merged commit ce446d2 into releases/3.53.1 Aug 28, 2025
28 checks passed
@kushagraThapar kushagraThapar deleted the users/aavasthy/hotfix_3.53.1 branch August 28, 2025 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enables automation to merge PRs
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants