TokenCredentialCache: Adds a fallback mechanism to AAD scope override. #5364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aavasthy
requested review from
FabianMeiswinkel,
Pilchie,
adityasa,
khdang,
kirankumarkolli,
kirillg,
neildsh and
sboshra
as code owners
Microsoft.Azure.Cosmos/src/Authorization/CosmosScopeProvider.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Authorization/CosmosScopeProvider.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Authorization/TokenCredentialCache.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Authorization/TokenCredentialCache.cs
Outdated
Show resolved
Hide resolved
ananth7592
previously approved these changes
Aug 21, 2025
Microsoft.Azure.Cosmos/src/Authorization/CosmosScopeProvider.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Authorization/TokenCredentialCache.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Authorization/TokenCredentialCache.cs
Outdated
Show resolved
Hide resolved
This was referenced Sep 8, 2025
This was referenced Oct 6, 2025
Merged
This was referenced Oct 13, 2025
This was referenced Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
It's a follow up for this PR #5252, which introduces the ability to override AAD scope value. As part of the current PR, use overridden scope if its provided and there is no fallback for this.
If no overridden scope is provided then use account scope and if this fails with exception AADSTS500011 then fallback to this scope "https://cosmos.azure.com/.default". Each scope continues to go through existing validations.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber