Skip to content

Conversation

@theo97490
Copy link
Contributor

📑 Description

Fix tbl extend on opts.config instead of opts

I believe this was a typo because assigning opts.config to a modified table of opts doesn't make sense

@github-actions
Copy link

github-actions bot commented Oct 2, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@theo97490 theo97490 changed the title Fix tbl extend on opts.config instead of opts fix(cpp): tbl extend on opts.config instead of opts Oct 2, 2024
@theo97490
Copy link
Contributor Author

Basicly i noticed there was an issue when i copied the pack.ccp to modify it in my own config ( by removing from the astrocommunity file and adding the init into the plugins folder ). I saw it resets all configurations. I noticed when i was using pack.python and the type strictness was enabled where it shouldn't be

Copy link
Member

@luxus luxus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@luxus luxus merged commit ed524d2 into AstroNvim:main Oct 3, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants