Dshot on iomcu #23974
Merged
Dshot on iomcu #23974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyp1per
force-pushed
the
pr-dshot-iomcu-8-channels
branch
from
7685229 to
2756d85
Compare
andyp1per
force-pushed
the
pr-dshot-iomcu-8-channels
branch
from
2756d85 to
42efc53
Compare
andyp1per
changed the title
andyp1per
force-pushed
the
pr-dshot-iomcu-8-channels
branch
from
139d2c9 to
82b573e
Compare
|
Locking mode 2 is much more efficient and reliable |
andyp1per
force-pushed
the
pr-dshot-iomcu-8-channels
branch
2 times, most recently
from
b3f472a to
4761d6e
Compare
|
delayed until next week's dev call. |
tridge
reviewed
Jun 21, 2023
tridge
requested changes
Jun 21, 2023
andyp1per
force-pushed
the
pr-dshot-iomcu-8-channels
branch
3 times, most recently
from
e337c6f to
614379a
Compare
|
1Mhz cannot be done on f103 without losing PPM. So as long as we are confident we have got all the f103 boards we can make this change. Not otherwise. |
|
Tested on Holybro Pixhawk6X |
andyp1per
force-pushed
the
pr-dshot-iomcu-8-channels
branch
2 times, most recently
from
8f11ff8 to
e87a71d
Compare
…ner for iomcu add support for undef of STM32 lines and DMA_NOMAP add support for F103 running at 24Mhz add f103 variants of iofirmware reduce memory usage in iomcu for new model correct pwm output reporting split iofirmware into config + mcu to allow f103 definition don't enable non-existant timers on F103
correctly update outmode modes when requested get ARM CPUID and display in startup banner ensure correct rc input timing on 1Khz iofirmware
…ts to avoid losing data
update for improved latency and mode setting add cpuid/mcuid reporting correct rc input timing on regular iofirmware update to support increased system clock on f103 and dshot600 update to support reversed and reversible masks
andyp1per
force-pushed
the
pr-dshot-iomcu-8-channels
branch
from
2a85a61 to
dc2670c
Compare
tridge
approved these changes
Aug 14, 2023
|
Did a quick retest on a cube black with the review changes 👍 |
|
Is this already implemented on 4.4.0 stable? |
No, 4.5 only |
Oh ok! That should take some months right? :( |
92 tasks
|
Just for the record, it looks like this PR has broken NeoPixel support on CubeOrangePlus in master and Copter-4.5.0. This is a big PR so I'm not too confident that I could get to the bottom of the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #21569
Working 8 channel updates. Quite a lot more hairy than the previous PR with the new eventing model.
Tested on a 5" quad on channels 1-4 with ds300 - constant memory and no errors:
Did a full autotune on the quad without issue