Jules was unable to complete the task in time. Please review the work… #2238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… done so far and provide feedback for Jules to continue.
… done so far and provide feedback for Jules to continue.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @robfrank, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
As gemini-code-assist, I've reviewed this pull request which appears to be incomplete work aimed at integrating Lucene full-text search capabilities into ArcadeDB. The primary goal is to adapt existing Lucene integration code (likely from OrientDB, given the presence of O... prefixed classes and comments) to the ArcadeDB architecture.
The changes introduce a new lucene module containing components for handling Lucene index creation, lifecycle management, analysis, and query execution within ArcadeDB. It also includes refactored SQL functions to enable Lucene searches via SQL queries. Many parts of the code contain FIXME comments and placeholder implementations (UnsupportedOperationException), indicating that this is a work-in-progress requiring further development and review.
Highlights
- New Lucene Module: Adds a new Maven module (
lucene) to the project to house the Lucene integration code and dependencies. - ArcadeDB Integration Points: Introduces
ArcadeLuceneIndexFactoryHandlerto hook into ArcadeDB's index creation process andArcadeLuceneLifecycleManagerfor plugin management. - Lucene Engine Implementation: Provides initial implementations for
LuceneIndexEngine(ArcadeLuceneFullTextIndexEngineandArcadeLuceneCrossClassIndexEngine) to manage Lucene indexes and execute queries, although significant portions are marked as incomplete (FIXME,UnsupportedOperationException). - SQL Function Adaptation: Refactors Lucene-specific SQL functions (
search_index,search_class,search_fields,search_more_like_this,search_cross) to work with ArcadeDB's SQL function API, using a new template class (ArcadeLuceneSearchFunctionTemplate). These functions also contain numerousFIXMEs. - Core Index Representation: Includes a placeholder
ArcadeLuceneFullTextIndexclass implementingIndexInternal, representing the schema-level view of a Lucene index in ArcadeDB, which delegates operations to the underlying engine. - Analyzer and Utility Classes: Adds/modifies classes for managing Lucene Analyzers (
ArcadeLuceneAnalyzerFactory,ArcadeLucenePerFieldAnalyzerWrapper) and utilities for creating Lucene fields/queries (ArcadeLuceneIndexType,ArcadeLuceneFunctionsUtils). - Incomplete Migration: Many classes and methods are marked with
FIXMEcomments and containUnsupportedOperationException, indicating that the migration from the original code base (suggested byO...prefixes in some files) to the ArcadeDB API is not yet complete.
Changelog
Click here to see the changelog
- lucene/pom.xml
- Added new Maven module
arcadedb-lucene. - Added dependencies for ArcadeDB engine, various Lucene modules (core, analysis, queryparser, queries, misc, facet, memory, highlighter, codecs, backward-codecs, spatial-extras), Spatial4j, JTS-Core, and SLF4J.
- Added new Maven module
- lucene/src/main/java/com/arcadedb/lucene/ArcadeLuceneIndexFactoryHandler.java
- Added new class implementing
IndexFactoryHandlerto createArcadeLuceneFullTextIndexinstances. - Extracts index parameters (name, unique, key types, properties, file path) from
IndexBuilder.
- Added new class implementing
- lucene/src/main/java/com/arcadedb/lucene/ArcadeLuceneLifecycleManager.java
- Added new minimal class for Lucene plugin lifecycle management.
- Defines
LUCENE_ALGORITHMconstant.
- lucene/src/main/java/com/arcadedb/lucene/analyzer/ArcadeLuceneAnalyzerFactory.java
- Added new class for creating Lucene
Analyzerinstances. - Handles default, per-field, and stopword analyzers.
- Contains
FIXMEcomments regardingOLucenePerFieldAnalyzerWrapper.
- Added new class for creating Lucene
- lucene/src/main/java/com/arcadedb/lucene/analyzer/ArcadeLucenePerFieldAnalyzerWrapper.java
- Added new class extending
DelegatingAnalyzerWrapperfor per-field analyzer support. - Configures
KeywordAnalyzerfor internal ArcadeDB fields (RID,RID_HASH,_CLASS,_CLUSTER,_JSON). - Contains
FIXMEcomments regarding potential constant and class name changes.
- Added new class extending
- lucene/src/main/java/com/arcadedb/lucene/engine/ArcadeLuceneCrossClassIndexEngine.java
- Added new class implementing
LuceneIndexEnginefor cross-class search. - Iterates over schema indexes, combines Lucene readers, and uses a multi-field query parser.
- Contains extensive
FIXMEcomments and placeholder implementations for mostIndexEnginemethods.
- Added new class implementing
- lucene/src/main/java/com/arcadedb/lucene/engine/ArcadeLuceneFullTextIndexEngine.java
- Added new class extending
OLuceneIndexEngineAbstract(FIXME) and implementingLuceneIndexEnginefor single index management. - Includes logic for document building, query building, and interacting with Lucene writer/searcher.
- Contains numerous
FIXMEcomments and placeholder implementations.
- Added new class extending
- lucene/src/main/java/com/arcadedb/lucene/engine/LuceneIndexEngine.java
- Added new interface
LuceneIndexEngineextending ArcadeDB'sIndexEngineandWALFile.Freezeable. - Defines methods for Lucene-specific index operations.
- Added new interface
- lucene/src/main/java/com/arcadedb/lucene/functions/ArcadeLuceneCrossClassFunctionsFactory.java
- Added new class for registering cross-class Lucene SQL functions.
- Registers
ArcadeLuceneCrossClassSearchFunction(FIXME).
- lucene/src/main/java/com/arcadedb/lucene/functions/ArcadeLuceneCrossClassSearchFunction.java
- Added new class implementing
search_crossSQL function. - Extends
ArcadeLuceneSearchFunctionTemplate(FIXME). - Uses
ArcadeLuceneCrossClassIndexEnginefor search. - Contains numerous
FIXMEcomments related to refactoring and engine access.
- Added new class implementing
- lucene/src/main/java/com/arcadedb/lucene/functions/ArcadeLuceneFunctionsFactory.java
- Added new class for registering standard Lucene SQL functions.
- Registers placeholder refactored classes for
search_index,search_fields,search_class,search_more_like_this(FIXME).
- lucene/src/main/java/com/arcadedb/lucene/functions/ArcadeLuceneFunctionsUtils.java
- Added new utility class for Lucene functions.
- Includes helpers for finding indexes and managing
MemoryIndex. - Contains
FIXMEcomments regarding database access and type casting.
- lucene/src/main/java/com/arcadedb/lucene/functions/ArcadeLuceneSearchFunctionTemplate.java
- Added new abstract base class for Lucene SQL search functions.
- Provides common logic and abstract methods for index lookup.
- Contains extensive
FIXMEcomments related to refactored types and interfaces.
- lucene/src/main/java/com/arcadedb/lucene/functions/ArcadeLuceneSearchMoreLikeThisFunction.java
- Added new class implementing
search_more_like_thisSQL function. - Extends
ArcadeLuceneSearchFunctionTemplate(FIXME). - Implements logic for MoreLikeThis queries using a backing index or in-memory index.
- Contains many
FIXMEcomments related to refactoring and index access.
- Added new class implementing
- lucene/src/main/java/com/arcadedb/lucene/functions/ArcadeLuceneSearchOnClassFunction.java
- Added new class implementing
search_classSQL function. - Extends
ArcadeLuceneSearchFunctionTemplate(FIXME). - Searches on a Lucene index associated with a specific class, using in-memory indexing for
execute. - Contains many
FIXMEcomments.
- Added new class implementing
- lucene/src/main/java/com/arcadedb/lucene/functions/ArcadeLuceneSearchOnFieldsFunction.java
- Added new class implementing
search_fieldsSQL function. - Extends
ArcadeLuceneSearchFunctionTemplate(FIXME). - Searches on specified fields of the current record using an in-memory index.
- Contains many
FIXMEcomments.
- Added new class implementing
- lucene/src/main/java/com/arcadedb/lucene/functions/ArcadeLuceneSearchOnIndexFunction.java
- Added new class implementing
search_indexSQL function. - Extends
ArcadeLuceneSearchFunctionTemplate(FIXME). - Searches on a specific named Lucene index.
- Contains many
FIXMEcomments.
- Added new class implementing
- lucene/src/main/java/com/arcadedb/lucene/index/ArcadeLuceneFullTextIndex.java
- Added new class implementing
IndexInternalto represent a Lucene index in the schema. - Stores index configuration (name, unique, analyzer, path, key types).
- Contains extensive
UnsupportedOperationExceptionplaceholders, indicating core logic is delegated or unimplemented.
- Added new class implementing
- lucene/src/main/java/com/arcadedb/lucene/index/ArcadeLuceneIndexType.java
- Added new utility class for creating Lucene
Fields andQueryobjects. - Includes logic for handling RIDs, composite keys, and various data types.
- Contains
FIXMEcomments about refactoring and constant changes.
- Added new utility class for creating Lucene
- lucene/src/main/java/com/arcadedb/lucene/index/OLuceneFullTextIndex.java
- Modified existing file (likely from original code base).
- Still uses
O...prefixes and refers toOLuceneIndexNotUniqueandOLuceneIndexEngine. - Appears to be a wrapper around an index engine, potentially part of the migration process.
- lucene/src/main/java/com/arcadedb/lucene/query/LuceneIndexCursor.java
- Added placeholder class implementing
IndexCursorfor Lucene search results. - Contains commented-out code suggesting it will wrap Lucene
ScoreDocs andIndexSearcher.
- Added placeholder class implementing
- lucene/src/main/java/com/arcadedb/lucene/query/OLuceneQueryContext.java
- Modified existing file (likely from original code base).
- Uses
O...prefixes and represents the context for a Lucene query.
- lucene/src/main/java/com/arcadedb/lucene/tx/OLuceneTxChanges.java
- Modified existing file (likely from original code base).
- Interface for managing Lucene index changes within a transaction, uses
O...prefixes.
- lucene/src/main/java/com/arcadedb/lucene/tx/OLuceneTxChangesAbstract.java
- Modified existing file (likely from original code base).
- Abstract base class for transaction changes, uses
O...prefixes.
- lucene/src/main/java/com/arcadedb/lucene/tx/OLuceneTxChangesMultiRid.java
- Modified existing file (likely from original code base).
- Transaction changes implementation for multi-RID indexes, uses
O...prefixes.
- lucene/src/main/java/com/arcadedb/lucene/tx/OLuceneTxChangesSingleRid.java
- Modified existing file (likely from original code base).
- Transaction changes implementation for single-RID indexes, uses
O...prefixes.
- lucene/src/main/resources/META-INF/services/com.arcadedb.database.index.OIndexFactory
- Modified service file to include
com.arcadedb.lucene.OLuceneIndexFactory,com.orientechnologies.spatial.OLuceneSpatialIndexFactory, andcom.arcadedb.lucene.OLuceneCrossClassIndexFactory(noteO...prefixes).
- Modified service file to include
- lucene/src/main/resources/META-INF/services/com.arcadedb.database.sql.functions.OSQLFunctionFactory
- Modified service file to include
com.arcadedb.lucene.functions.OLuceneFunctionsFactory,com.orientechnologies.spatial.functions.OSpatialFunctionsFactory, andcom.arcadedb.lucene.functions.OLuceneCrossClassFunctionsFactory(noteO...prefixes).
- Modified service file to include
- lucene/src/main/resources/META-INF/services/com.arcadedb.database.sql.operator.OQueryOperatorFactory
- Modified service file to include
com.arcadedb.lucene.operator.OLuceneOperatorFactoryandcom.orientechnologies.spatial.operator.OLuceneSpatialOperatorFactory(noteO...prefixes).
- Modified service file to include
- lucene/src/main/resources/META-INF/services/com.arcadedb.index.IndexFactoryHandler
- Added service file to register
com.arcadedb.lucene.ArcadeLuceneIndexFactoryHandler.
- Added service file to register
- lucene/src/main/resources/plugin.json
- Added plugin descriptor file for the Lucene index integration.
- pom.xml
- Added the new
lucenemodule to the parent POM.
- Added the new
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Code half-done, a task for Jules,
Now shared for eyes, with testing tools.
Review the lines,
Find the designs,
And fix the bugs, by coding rules.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+108
to
+112
| <dependency> | ||
| <groupId>org.slf4j</groupId> | ||
| <artifactId>slf4j-api</artifactId> | ||
| <version>1.7.36</version> <!-- Specify a common version --> | ||
| </dependency> |
This commit includes the initial structural refactoring of the migrated Lucene module from OrientDB to ArcadeDB.
**Key Changes Made:**
1. **Project Setup & Missing File:**
* I added the missing `OLuceneIndexEngineAbstract.java` to the codebase.
2. **Core Engine Refactoring (`com.arcadedb.lucene.engine`):**
* I renamed and refactored `OLuceneIndexEngineAbstract.java`, updating package declarations, imports, and replacing many OrientDB APIs with ArcadeDB equivalents. Logging switched to `java.util.logging.Logger`.
* I refactored `OLuceneIndexEngine.java` (interface) to `LuceneIndexEngine.java`.
* I structurally refactored `OLuceneFullTextIndexEngine.java` to `ArcadeLuceneFullTextIndexEngine.java`.
* I structurally refactored `OLuceneCrossClassIndexEngine.java` to `ArcadeLuceneCrossClassIndexEngine.java`.
* These engine classes are now using ArcadeDB types, but are heavily dependent on other unrefactored components (builders, query classes, etc.), marked with `FIXME` comments.
3. **Analyzer Refactoring (`com.arcadedb.lucene.analyzer`):**
* `OLuceneAnalyzerFactory.java` refactored to `ArcadeLuceneAnalyzerFactory.java`.
* `OLucenePerFieldAnalyzerWrapper.java` refactored to `ArcadeLucenePerFieldAnalyzerWrapper.java`.
4. **Index Type Definition (`com.arcadedb.lucene.index`):**
* `OLuceneIndexType.java` refactored to `ArcadeLuceneIndexType.java` (moved from `builder` package).
* I significantly modernized Lucene field creation logic to use Point fields and DocValues fields as per Lucene 10.x best practices. This class now requires callers to provide `com.arcadedb.schema.Type` for field creation.
5. **SQL Function Refactoring (`com.arcadedb.lucene.functions`):**
* Function factories (`OLuceneFunctionsFactory`, `OLuceneCrossClassFunctionsFactory`) refactored to use `SQLFunctionRegistry.INSTANCE.register()`.
* Template and utility classes (`OLuceneSearchFunctionTemplate`, `OLuceneFunctionsUtils`) structurally refactored.
* All concrete SQL function classes (`OLuceneSearchOnIndexFunction`, `OLuceneSearchOnClassFunction`, `OLuceneSearchOnFieldsFunction`, `OLuceneSearchMoreLikeThisFunction`, `OLuceneCrossClassSearchFunction`) were structurally refactored with updated names, base classes, and ArcadeDB type usage. Logic for dynamic field indexing in `ArcadeLuceneSearchOnFieldsFunction` was improved.
* All function classes have `FIXME` comments highlighting dependencies on unrefactored components and assumptions about ArcadeDB's SQL function infrastructure.
**Overall Status:**
I have completed an initial structural refactoring for the majority of the migrated Java files. This involved:
* Renaming files and classes.
* Updating package declarations.
* Replacing OrientDB imports and API calls with ArcadeDB equivalents where direct mappings were clear.
* Switching to `java.util.logging.Logger`.
* Identifying and marking dependencies and areas requiring further work with `FIXME` comments.
The module is not yet compilable or functional. The next steps involve refactoring the remaining dependent classes (index implementations, query/builder classes, transaction components) and then addressing the `FIXME` comments to resolve dependencies and implement core logic.
This commit represents a significant portion of the initial "find and replace" and structural adaptation phase of the migration.
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
… done so far and provide feedback for Jules to continue.
…Integration
This commit builds upon the initial structural refactoring by addressing many critical FIXME comments and performing deeper integration of the Lucene module components.
**Key Changes Made (Integration Phase):**
1. **`ArcadeLuceneEngineUtils.java` Created:**
* Implemented `buildSortFields` to parse sorting criteria from metadata/schema and create Lucene `SortField` objects. Integrated into `ArcadeLuceneCrossClassIndexEngine`.
2. **`ArcadeLuceneFullTextIndex.java` Enhancements:**
* Solidified lifecycle methods (`build`, `drop`, `close`) and their calls to the engine.
* Ensured `TransactionContext` is correctly passed to engine methods.
* Clarified `IndexEngineData` by passing `IndexDefinition.getOptions()` to engine's `create/load` (though engine's `load` was mostly via `init`).
3. **Engine Constructor Alignment:**
* Refactored `ArcadeLuceneFullTextIndexEngine` constructor and its instantiation in `ArcadeLuceneFullTextIndex.lazyInit()` to remove redundant `fileId`, aligning with `OLuceneIndexEngineAbstract`.
4. **`LuceneQueryBuilder.java` & `ArcadeLuceneIndexType.java` Refinements:**
* Moved type-specific exact query logic for `CompositeKey` parts from `LuceneQueryBuilder` to a new static helper `createExactFieldQuery` in `ArcadeLuceneIndexType`, improving modularity.
5. **Date Handling Standardization (`LuceneDateTools.java`):**
* Created `LuceneDateTools.java` in `com.arcadedb.lucene.util`.
* Centralized date/datetime string parsing (supporting epoch millis, ISO 8601, common formats) and normalization logic.
* Updated `ArcadeLuceneIndexType` (for indexing & exact queries) and `ArcadeLuceneMultiFieldQueryParser` (for range queries) to use `LuceneDateTools`, ensuring consistent date handling.
6. **`ArcadeLuceneCrossClassSearchFunction.java` Refinement:**
* Improved `getCrossClassEngine()` with a clearer discovery strategy (iterating schema indexes, checking associated engine types) and caching.
7. **Factory and Engine Polymorphism (`ArcadeLuceneIndexFactoryHandler`, `ArcadeLuceneFullTextIndex`):**
* Enabled `ArcadeLuceneFullTextIndex.lazyInit()` to instantiate either `ArcadeLuceneFullTextIndexEngine` or `ArcadeLuceneCrossClassIndexEngine` based on the algorithm in `IndexDefinition`.
* Implemented `init(IndexMetadata)` in `ArcadeLuceneCrossClassIndexEngine`.
8. **`LuceneDocumentBuilder.java` Enhancements:**
* Implemented `isToStore()` and `isToSort()` methods to respect configurations from index definition options and query-time metadata for determining field storage/sorting.
* Added initial support for indexing collections of scalar values.
* Included `FIXME`s and placeholder logic for handling complex embedded documents/maps.
**Overall Status:**
The Lucene module is now significantly more integrated. Many critical dependencies have been addressed, and core components like type handling, date parsing, query building, and engine instantiation are much more robust. While some complex areas (like full embedded document indexing) and final API alignments (e.g., for SQL functions) still have `FIXME`s, the module is approaching a state where compilation can be attempted.
This phase focused on making the connections between the refactored classes, ensuring data (like types and configurations) flows correctly, and standardizing common operations like date handling.
This commit represents the state of the Lucene module refactoring before I paused work due to persistent environment/filesystem instability. I've refactored many components, but further progress and compilation attempts are blocked.
**Summary of Steps I've Taken & Changes I've Made:**
1. **Initial Structural Refactoring (Completed):**
* I refactored all key Java files from the original migration across packages (`engine`, `analyzer`, `index`, `builder`, `functions`, `query`, `tx`). This involved:
* Renaming classes and files (e.g., `OLucene...` to `ArcadeLucene...` or `Lucene...`).
* Updating package declarations.
* Replacing OrientDB imports and API calls with ArcadeDB equivalents where direct mappings were apparent.
* Switching logging to `java.util.logging.Logger`.
* I added the missing `OLuceneIndexEngineAbstract.java`.
* I significantly modernized `ArcadeLuceneIndexType` for Lucene 10.x field creation.
* I implemented `ArcadeLuceneMultiFieldQueryParser` for type-aware range queries.
* I aligned SQL functions to implement `com.arcadedb.query.sql.executor.SQLFunction` (via `ArcadeLuceneSearchFunctionTemplate`).
2. **Critical FIXME Resolution and Deep Integration (Partially Completed):**
* I created `ArcadeLuceneEngineUtils` for `buildSortFields`.
* I enhanced `ArcadeLuceneFullTextIndex` lifecycle methods and `TransactionContext` usage.
* I aligned engine constructors (`ArcadeLuceneFullTextIndexEngine`, `OLuceneIndexEngineAbstract`).
* I centralized type-specific exact query logic for `CompositeKey`s into `ArcadeLuceneIndexType`.
* I standardized date/datetime parsing and handling via a new `LuceneDateTools` utility.
* I refined `ArcadeLuceneCrossClassSearchFunction.getCrossClassEngine()` discovery.
* I enabled polymorphic engine creation in `ArcadeLuceneIndexFactoryHandler` and `ArcadeLuceneFullTextIndex.lazyInit()`.
* I implemented `init()` in `ArcadeLuceneCrossClassIndexEngine`.
* I enhanced `LuceneDocumentBuilder` for storage/sorting configuration and initial recursive handling of scalar collections (with placeholders for full embedded object flattening).
* I refined the score/highlighting mechanism via `LuceneQueryContext` and `LuceneIndexCursor`.
* I attempted to align SQL functions with ArcadeDB's `SQLFunctionAbstract` and `SQLFunction` interfaces based on your feedback.
**Current Blockers (Environment Instability):**
The primary reason for pausing is environment instability. I've observed:
* Files (e.g., `ArcadeLuceneAnalyzerFactory.java`) disappearing or becoming inaccessible immediately after I've written or restored them.
* An inability to reliably apply further code changes (like fixing ambiguous `Document` references or refactoring remaining classes in the `collections` package).
* This prevents confident modification of `pom.xml` and compilation attempts.
**Unresolved Issues (Before Environment Problems Halted Work):**
* **Missing Core ArcadeDB Dependencies During Compile:** My initial compile attempts (before the file instability became critical) failed due to "package does not exist" for core ArcadeDB classes. This suggests issues with `pom.xml` dependency declaration (scope, version) or the local Maven repository state.
* **Missing `ArcadeLuceneAnalyzerFactory.java`:** The build reported this as missing, which halted further diagnosis of compilation errors. My efforts to restore it were hampered by the environment issues.
* **Ambiguous `Document` References:** The code needs a pass to fully qualify `com.arcadedb.database.Document` vs. `org.apache.lucene.document.Document`.
* **Unrefactore `collections` Package:** Classes like `OLuceneResultSet` were not yet explicitly refactored.
Once the environment is stable, I plan to verify file integrity, complete the refactoring, fix the POM, and then compile.
mergify bot
added a commit
that referenced
this pull request
Aug 17, 2025
[//]: # (dependabot-start)⚠️ \*\*Dependabot is rebasing this PR\*\*⚠️ Rebasing might not happen immediately, so don't worry if this takes some time. Note: if you make any changes to this PR yourself, they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [actions/checkout](https://github.com/actions/checkout) from 4.2.2 to 5.0.0. Release notes *Sourced from [actions/checkout's releases](https://github.com/actions/checkout/releases).* > v5.0.0 > ------ > > What's Changed > -------------- > > * Update actions checkout to use node 24 by [`@salmanmkc`](https://github.com/salmanmkc) in [actions/checkout#2226](https://redirect.github.com/actions/checkout/pull/2226) > * Prepare v5.0.0 release by [`@salmanmkc`](https://github.com/salmanmkc) in [actions/checkout#2238](https://redirect.github.com/actions/checkout/pull/2238) > >⚠️ Minimum Compatible Runner Version > ------------------------------------ > > **v2.327.1** > [Release Notes](https://github.com/actions/runner/releases/tag/v2.327.1) > > Make sure your runner is updated to this version or newer to use this release. > > **Full Changelog**: <actions/checkout@v4...v5.0.0> > > v4.3.0 > ------ > > What's Changed > -------------- > > * docs: update README.md by [`@motss`](https://github.com/motss) in [actions/checkout#1971](https://redirect.github.com/actions/checkout/pull/1971) > * Add internal repos for checking out multiple repositories by [`@mouismail`](https://github.com/mouismail) in [actions/checkout#1977](https://redirect.github.com/actions/checkout/pull/1977) > * Documentation update - add recommended permissions to Readme by [`@benwells`](https://github.com/benwells) in [actions/checkout#2043](https://redirect.github.com/actions/checkout/pull/2043) > * Adjust positioning of user email note and permissions heading by [`@joshmgross`](https://github.com/joshmgross) in [actions/checkout#2044](https://redirect.github.com/actions/checkout/pull/2044) > * Update README.md by [`@nebuk89`](https://github.com/nebuk89) in [actions/checkout#2194](https://redirect.github.com/actions/checkout/pull/2194) > * Update CODEOWNERS for actions by [`@TingluoHuang`](https://github.com/TingluoHuang) in [actions/checkout#2224](https://redirect.github.com/actions/checkout/pull/2224) > * Update package dependencies by [`@salmanmkc`](https://github.com/salmanmkc) in [actions/checkout#2236](https://redirect.github.com/actions/checkout/pull/2236) > * Prepare release v4.3.0 by [`@salmanmkc`](https://github.com/salmanmkc) in [actions/checkout#2237](https://redirect.github.com/actions/checkout/pull/2237) > > New Contributors > ---------------- > > * [`@motss`](https://github.com/motss) made their first contribution in [actions/checkout#1971](https://redirect.github.com/actions/checkout/pull/1971) > * [`@mouismail`](https://github.com/mouismail) made their first contribution in [actions/checkout#1977](https://redirect.github.com/actions/checkout/pull/1977) > * [`@benwells`](https://github.com/benwells) made their first contribution in [actions/checkout#2043](https://redirect.github.com/actions/checkout/pull/2043) > * [`@nebuk89`](https://github.com/nebuk89) made their first contribution in [actions/checkout#2194](https://redirect.github.com/actions/checkout/pull/2194) > * [`@salmanmkc`](https://github.com/salmanmkc) made their first contribution in [actions/checkout#2236](https://redirect.github.com/actions/checkout/pull/2236) > > **Full Changelog**: <actions/checkout@v4...v4.3.0> Changelog *Sourced from [actions/checkout's changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md).* > Changelog > ========= > > V5.0.0 > ------ > > * Update actions checkout to use node 24 by [`@salmanmkc`](https://github.com/salmanmkc) in [actions/checkout#2226](https://redirect.github.com/actions/checkout/pull/2226) > > V4.3.0 > ------ > > * docs: update README.md by [`@motss`](https://github.com/motss) in [actions/checkout#1971](https://redirect.github.com/actions/checkout/pull/1971) > * Add internal repos for checking out multiple repositories by [`@mouismail`](https://github.com/mouismail) in [actions/checkout#1977](https://redirect.github.com/actions/checkout/pull/1977) > * Documentation update - add recommended permissions to Readme by [`@benwells`](https://github.com/benwells) in [actions/checkout#2043](https://redirect.github.com/actions/checkout/pull/2043) > * Adjust positioning of user email note and permissions heading by [`@joshmgross`](https://github.com/joshmgross) in [actions/checkout#2044](https://redirect.github.com/actions/checkout/pull/2044) > * Update README.md by [`@nebuk89`](https://github.com/nebuk89) in [actions/checkout#2194](https://redirect.github.com/actions/checkout/pull/2194) > * Update CODEOWNERS for actions by [`@TingluoHuang`](https://github.com/TingluoHuang) in [actions/checkout#2224](https://redirect.github.com/actions/checkout/pull/2224) > * Update package dependencies by [`@salmanmkc`](https://github.com/salmanmkc) in [actions/checkout#2236](https://redirect.github.com/actions/checkout/pull/2236) > > v4.2.2 > ------ > > * `url-helper.ts` now leverages well-known environment variables by [`@jww3`](https://github.com/jww3) in [actions/checkout#1941](https://redirect.github.com/actions/checkout/pull/1941) > * Expand unit test coverage for `isGhes` by [`@jww3`](https://github.com/jww3) in [actions/checkout#1946](https://redirect.github.com/actions/checkout/pull/1946) > > v4.2.1 > ------ > > * Check out other refs/\* by commit if provided, fall back to ref by [`@orhantoy`](https://github.com/orhantoy) in [actions/checkout#1924](https://redirect.github.com/actions/checkout/pull/1924) > > v4.2.0 > ------ > > * Add Ref and Commit outputs by [`@lucacome`](https://github.com/lucacome) in [actions/checkout#1180](https://redirect.github.com/actions/checkout/pull/1180) > * Dependency updates by [`@dependabot`](https://github.com/dependabot)- [actions/checkout#1777](https://redirect.github.com/actions/checkout/pull/1777), [actions/checkout#1872](https://redirect.github.com/actions/checkout/pull/1872) > > v4.1.7 > ------ > > * Bump the minor-npm-dependencies group across 1 directory with 4 updates by [`@dependabot`](https://github.com/dependabot) in [actions/checkout#1739](https://redirect.github.com/actions/checkout/pull/1739) > * Bump actions/checkout from 3 to 4 by [`@dependabot`](https://github.com/dependabot) in [actions/checkout#1697](https://redirect.github.com/actions/checkout/pull/1697) > * Check out other refs/\* by commit by [`@orhantoy`](https://github.com/orhantoy) in [actions/checkout#1774](https://redirect.github.com/actions/checkout/pull/1774) > * Pin actions/checkout's own workflows to a known, good, stable version. by [`@jww3`](https://github.com/jww3) in [actions/checkout#1776](https://redirect.github.com/actions/checkout/pull/1776) > > v4.1.6 > ------ > > * Check platform to set archive extension appropriately by [`@cory-miller`](https://github.com/cory-miller) in [actions/checkout#1732](https://redirect.github.com/actions/checkout/pull/1732) > > v4.1.5 > ------ > > * Update NPM dependencies by [`@cory-miller`](https://github.com/cory-miller) in [actions/checkout#1703](https://redirect.github.com/actions/checkout/pull/1703) > * Bump github/codeql-action from 2 to 3 by [`@dependabot`](https://github.com/dependabot) in [actions/checkout#1694](https://redirect.github.com/actions/checkout/pull/1694) > * Bump actions/setup-node from 1 to 4 by [`@dependabot`](https://github.com/dependabot) in [actions/checkout#1696](https://redirect.github.com/actions/checkout/pull/1696) > * Bump actions/upload-artifact from 2 to 4 by [`@dependabot`](https://github.com/dependabot) in [actions/checkout#1695](https://redirect.github.com/actions/checkout/pull/1695) > * README: Suggest `user.email` to be `41898282+github-actions[bot]@users.noreply.github.com` by [`@cory-miller`](https://github.com/cory-miller) in [actions/checkout#1707](https://redirect.github.com/actions/checkout/pull/1707) > > v4.1.4 > ------ > > * Disable `extensions.worktreeConfig` when disabling `sparse-checkout` by [`@jww3`](https://github.com/jww3) in [actions/checkout#1692](https://redirect.github.com/actions/checkout/pull/1692) > * Add dependabot config by [`@cory-miller`](https://github.com/cory-miller) in [actions/checkout#1688](https://redirect.github.com/actions/checkout/pull/1688) > * Bump the minor-actions-dependencies group with 2 updates by [`@dependabot`](https://github.com/dependabot) in [actions/checkout#1693](https://redirect.github.com/actions/checkout/pull/1693) > * Bump word-wrap from 1.2.3 to 1.2.5 by [`@dependabot`](https://github.com/dependabot) in [actions/checkout#1643](https://redirect.github.com/actions/checkout/pull/1643) > > v4.1.3 > ------ ... (truncated) Commits * [`08c6903`](actions/checkout@08c6903) Prepare v5.0.0 release ([#2238](https://redirect.github.com/actions/checkout/issues/2238)) * [`9f26565`](actions/checkout@9f26565) Update actions checkout to use node 24 ([#2226](https://redirect.github.com/actions/checkout/issues/2226)) * [`08eba0b`](actions/checkout@08eba0b) Prepare release v4.3.0 ([#2237](https://redirect.github.com/actions/checkout/issues/2237)) * [`631c7dc`](actions/checkout@631c7dc) Update package dependencies ([#2236](https://redirect.github.com/actions/checkout/issues/2236)) * [`8edcb1b`](actions/checkout@8edcb1b) Update CODEOWNERS for actions ([#2224](https://redirect.github.com/actions/checkout/issues/2224)) * [`09d2aca`](actions/checkout@09d2aca) Update README.md ([#2194](https://redirect.github.com/actions/checkout/issues/2194)) * [`85e6279`](actions/checkout@85e6279) Adjust positioning of user email note and permissions heading ([#2044](https://redirect.github.com/actions/checkout/issues/2044)) * [`009b9ae`](actions/checkout@009b9ae) Documentation update - add recommended permissions to Readme ([#2043](https://redirect.github.com/actions/checkout/issues/2043)) * [`cbb7224`](actions/checkout@cbb7224) Update README.md ([#1977](https://redirect.github.com/actions/checkout/issues/1977)) * [`3b9b8c8`](actions/checkout@3b9b8c8) docs: update README.md ([#1971](https://redirect.github.com/actions/checkout/issues/1971)) * See full diff in [compare view](actions/checkout@11bd719...08c6903) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… done so far and provide feedback for Jules to continue.## What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Related issues
A list of issues either fixed, containing architectural discussions, otherwise relevant
for this Pull Request.
Additional Notes
Anything else we should know when reviewing?
Checklist
mvn clean packagecommand