Skip to content

fixed notify usage in JS | fixes #1976 #1977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ExtReMLapin
Copy link
Contributor

What does this PR do?

Fixes $notify usage in javascript and fixes #1976 1976

Motivation

It was driving me INSANE

Related issues

A list of issues either fixed, containing architectural discussions, otherwise relevant
for this Pull Request.

Additional Notes

tested and compiled on ubuntu as build server, windows as frontend test, it works

image

@gramian
Copy link
Collaborator

gramian commented Feb 13, 2025

I totally get it, and I agree it should be moved. But if it is at the bottom right you have to move your view (your eyes) from the top where you enter the query and press the button. So what do you think about having the error coming in from the top and align to the center if possible?

@ExtReMLapin
Copy link
Contributor Author

Agree on your point.
I would have moved it to the left side, I just fixed the way it was called. Didn't want to take any initiative.

Will look after finishing trying to fix the db sync issues on the frontend with the different select dom

@robfrank robfrank requested a review from lvca February 13, 2025 10:34
@lvca lvca added this to the 25.2.1 milestone Feb 13, 2025
@lvca lvca added the bug Something isn't working label Feb 13, 2025
@lvca
Copy link
Contributor

lvca commented Feb 13, 2025

Thanks @ExtReMLapin for these contributions!

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (491192c) 68451 43994 64.27%
Head commit (491192c) 68451 (+0) 43994 (+0) 64.27% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1977) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@ExtReMLapin ExtReMLapin reopened this Feb 13, 2025
@ExtReMLapin
Copy link
Contributor Author

Re-opened the PR, last time I trust chatGPT for git...
Anyway, it's now centered

image

@gramian gramian mentioned this pull request Feb 14, 2025
@gramian gramian closed this Feb 18, 2025
@ExtReMLapin ExtReMLapin deleted the fix-notify-position branch February 18, 2025 19:41
mergify bot added a commit that referenced this pull request Aug 17, 2025
[//]: # (dependabot-start)
⚠️ \*\*Dependabot is rebasing this PR\*\* ⚠️
Rebasing might not happen immediately, so don't worry if this takes some time.
Note: if you make any changes to this PR yourself, they will take precedence over the rebase.
---
[//]: # (dependabot-end)
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.2.2 to 5.0.0.
Release notes

*Sourced from [actions/checkout's releases](https://github.com/actions/checkout/releases).*

> v5.0.0
> ------
>
> What's Changed
> --------------
>
> * Update actions checkout to use node 24 by [`@​salmanmkc`](https://github.com/salmanmkc) in [actions/checkout#2226](https://redirect.github.com/actions/checkout/pull/2226)
> * Prepare v5.0.0 release by [`@​salmanmkc`](https://github.com/salmanmkc) in [actions/checkout#2238](https://redirect.github.com/actions/checkout/pull/2238)
>
> ⚠️ Minimum Compatible Runner Version
> ------------------------------------
>
> **v2.327.1**  
> [Release Notes](https://github.com/actions/runner/releases/tag/v2.327.1)
>
> Make sure your runner is updated to this version or newer to use this release.
>
> **Full Changelog**: <actions/checkout@v4...v5.0.0>
>
> v4.3.0
> ------
>
> What's Changed
> --------------
>
> * docs: update README.md by [`@​motss`](https://github.com/motss) in [actions/checkout#1971](https://redirect.github.com/actions/checkout/pull/1971)
> * Add internal repos for checking out multiple repositories by [`@​mouismail`](https://github.com/mouismail) in [actions/checkout#1977](https://redirect.github.com/actions/checkout/pull/1977)
> * Documentation update - add recommended permissions to Readme by [`@​benwells`](https://github.com/benwells) in [actions/checkout#2043](https://redirect.github.com/actions/checkout/pull/2043)
> * Adjust positioning of user email note and permissions heading by [`@​joshmgross`](https://github.com/joshmgross) in [actions/checkout#2044](https://redirect.github.com/actions/checkout/pull/2044)
> * Update README.md by [`@​nebuk89`](https://github.com/nebuk89) in [actions/checkout#2194](https://redirect.github.com/actions/checkout/pull/2194)
> * Update CODEOWNERS for actions by [`@​TingluoHuang`](https://github.com/TingluoHuang) in [actions/checkout#2224](https://redirect.github.com/actions/checkout/pull/2224)
> * Update package dependencies by [`@​salmanmkc`](https://github.com/salmanmkc) in [actions/checkout#2236](https://redirect.github.com/actions/checkout/pull/2236)
> * Prepare release v4.3.0 by [`@​salmanmkc`](https://github.com/salmanmkc) in [actions/checkout#2237](https://redirect.github.com/actions/checkout/pull/2237)
>
> New Contributors
> ----------------
>
> * [`@​motss`](https://github.com/motss) made their first contribution in [actions/checkout#1971](https://redirect.github.com/actions/checkout/pull/1971)
> * [`@​mouismail`](https://github.com/mouismail) made their first contribution in [actions/checkout#1977](https://redirect.github.com/actions/checkout/pull/1977)
> * [`@​benwells`](https://github.com/benwells) made their first contribution in [actions/checkout#2043](https://redirect.github.com/actions/checkout/pull/2043)
> * [`@​nebuk89`](https://github.com/nebuk89) made their first contribution in [actions/checkout#2194](https://redirect.github.com/actions/checkout/pull/2194)
> * [`@​salmanmkc`](https://github.com/salmanmkc) made their first contribution in [actions/checkout#2236](https://redirect.github.com/actions/checkout/pull/2236)
>
> **Full Changelog**: <actions/checkout@v4...v4.3.0>


Changelog

*Sourced from [actions/checkout's changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md).*

> Changelog
> =========
>
> V5.0.0
> ------
>
> * Update actions checkout to use node 24 by [`@​salmanmkc`](https://github.com/salmanmkc) in [actions/checkout#2226](https://redirect.github.com/actions/checkout/pull/2226)
>
> V4.3.0
> ------
>
> * docs: update README.md by [`@​motss`](https://github.com/motss) in [actions/checkout#1971](https://redirect.github.com/actions/checkout/pull/1971)
> * Add internal repos for checking out multiple repositories by [`@​mouismail`](https://github.com/mouismail) in [actions/checkout#1977](https://redirect.github.com/actions/checkout/pull/1977)
> * Documentation update - add recommended permissions to Readme by [`@​benwells`](https://github.com/benwells) in [actions/checkout#2043](https://redirect.github.com/actions/checkout/pull/2043)
> * Adjust positioning of user email note and permissions heading by [`@​joshmgross`](https://github.com/joshmgross) in [actions/checkout#2044](https://redirect.github.com/actions/checkout/pull/2044)
> * Update README.md by [`@​nebuk89`](https://github.com/nebuk89) in [actions/checkout#2194](https://redirect.github.com/actions/checkout/pull/2194)
> * Update CODEOWNERS for actions by [`@​TingluoHuang`](https://github.com/TingluoHuang) in [actions/checkout#2224](https://redirect.github.com/actions/checkout/pull/2224)
> * Update package dependencies by [`@​salmanmkc`](https://github.com/salmanmkc) in [actions/checkout#2236](https://redirect.github.com/actions/checkout/pull/2236)
>
> v4.2.2
> ------
>
> * `url-helper.ts` now leverages well-known environment variables by [`@​jww3`](https://github.com/jww3) in [actions/checkout#1941](https://redirect.github.com/actions/checkout/pull/1941)
> * Expand unit test coverage for `isGhes` by [`@​jww3`](https://github.com/jww3) in [actions/checkout#1946](https://redirect.github.com/actions/checkout/pull/1946)
>
> v4.2.1
> ------
>
> * Check out other refs/\* by commit if provided, fall back to ref by [`@​orhantoy`](https://github.com/orhantoy) in [actions/checkout#1924](https://redirect.github.com/actions/checkout/pull/1924)
>
> v4.2.0
> ------
>
> * Add Ref and Commit outputs by [`@​lucacome`](https://github.com/lucacome) in [actions/checkout#1180](https://redirect.github.com/actions/checkout/pull/1180)
> * Dependency updates by [`@​dependabot`](https://github.com/dependabot)- [actions/checkout#1777](https://redirect.github.com/actions/checkout/pull/1777), [actions/checkout#1872](https://redirect.github.com/actions/checkout/pull/1872)
>
> v4.1.7
> ------
>
> * Bump the minor-npm-dependencies group across 1 directory with 4 updates by [`@​dependabot`](https://github.com/dependabot) in [actions/checkout#1739](https://redirect.github.com/actions/checkout/pull/1739)
> * Bump actions/checkout from 3 to 4 by [`@​dependabot`](https://github.com/dependabot) in [actions/checkout#1697](https://redirect.github.com/actions/checkout/pull/1697)
> * Check out other refs/\* by commit by [`@​orhantoy`](https://github.com/orhantoy) in [actions/checkout#1774](https://redirect.github.com/actions/checkout/pull/1774)
> * Pin actions/checkout's own workflows to a known, good, stable version. by [`@​jww3`](https://github.com/jww3) in [actions/checkout#1776](https://redirect.github.com/actions/checkout/pull/1776)
>
> v4.1.6
> ------
>
> * Check platform to set archive extension appropriately by [`@​cory-miller`](https://github.com/cory-miller) in [actions/checkout#1732](https://redirect.github.com/actions/checkout/pull/1732)
>
> v4.1.5
> ------
>
> * Update NPM dependencies by [`@​cory-miller`](https://github.com/cory-miller) in [actions/checkout#1703](https://redirect.github.com/actions/checkout/pull/1703)
> * Bump github/codeql-action from 2 to 3 by [`@​dependabot`](https://github.com/dependabot) in [actions/checkout#1694](https://redirect.github.com/actions/checkout/pull/1694)
> * Bump actions/setup-node from 1 to 4 by [`@​dependabot`](https://github.com/dependabot) in [actions/checkout#1696](https://redirect.github.com/actions/checkout/pull/1696)
> * Bump actions/upload-artifact from 2 to 4 by [`@​dependabot`](https://github.com/dependabot) in [actions/checkout#1695](https://redirect.github.com/actions/checkout/pull/1695)
> * README: Suggest `user.email` to be `41898282+github-actions[bot]@users.noreply.github.com` by [`@​cory-miller`](https://github.com/cory-miller) in [actions/checkout#1707](https://redirect.github.com/actions/checkout/pull/1707)
>
> v4.1.4
> ------
>
> * Disable `extensions.worktreeConfig` when disabling `sparse-checkout` by [`@​jww3`](https://github.com/jww3) in [actions/checkout#1692](https://redirect.github.com/actions/checkout/pull/1692)
> * Add dependabot config by [`@​cory-miller`](https://github.com/cory-miller) in [actions/checkout#1688](https://redirect.github.com/actions/checkout/pull/1688)
> * Bump the minor-actions-dependencies group with 2 updates by [`@​dependabot`](https://github.com/dependabot) in [actions/checkout#1693](https://redirect.github.com/actions/checkout/pull/1693)
> * Bump word-wrap from 1.2.3 to 1.2.5 by [`@​dependabot`](https://github.com/dependabot) in [actions/checkout#1643](https://redirect.github.com/actions/checkout/pull/1643)
>
> v4.1.3
> ------

... (truncated)


Commits

* [`08c6903`](actions/checkout@08c6903) Prepare v5.0.0 release ([#2238](https://redirect.github.com/actions/checkout/issues/2238))
* [`9f26565`](actions/checkout@9f26565) Update actions checkout to use node 24 ([#2226](https://redirect.github.com/actions/checkout/issues/2226))
* [`08eba0b`](actions/checkout@08eba0b) Prepare release v4.3.0 ([#2237](https://redirect.github.com/actions/checkout/issues/2237))
* [`631c7dc`](actions/checkout@631c7dc) Update package dependencies ([#2236](https://redirect.github.com/actions/checkout/issues/2236))
* [`8edcb1b`](actions/checkout@8edcb1b) Update CODEOWNERS for actions ([#2224](https://redirect.github.com/actions/checkout/issues/2224))
* [`09d2aca`](actions/checkout@09d2aca) Update README.md ([#2194](https://redirect.github.com/actions/checkout/issues/2194))
* [`85e6279`](actions/checkout@85e6279) Adjust positioning of user email note and permissions heading ([#2044](https://redirect.github.com/actions/checkout/issues/2044))
* [`009b9ae`](actions/checkout@009b9ae) Documentation update - add recommended permissions to Readme ([#2043](https://redirect.github.com/actions/checkout/issues/2043))
* [`cbb7224`](actions/checkout@cbb7224) Update README.md ([#1977](https://redirect.github.com/actions/checkout/issues/1977))
* [`3b9b8c8`](actions/checkout@3b9b8c8) docs: update README.md ([#1971](https://redirect.github.com/actions/checkout/issues/1971))
* See full diff in [compare view](actions/checkout@11bd719...08c6903)
  
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=actions/checkout&package-manager=github\_actions&previous-version=4.2.2&new-version=5.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STUDIO error notification modal goes OVER the 'sent button'
3 participants