Skip to content

refactor(Classic Footer): Combine noReblogMenu link addition with main code #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2025
Merged

refactor(Classic Footer): Combine noReblogMenu link addition with main code #1968

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61b13d1
refactor noReblogMenu link addition
marcustyphoon Nov 6, 2025
d68798c
consistent controls-not-found handling
marcustyphoon Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 20 additions & 22 deletions src/features/classic_footer/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ const reblogMenuPortalSelector = 'div[id^="portal/"]:has(div[role="menu"] a[role
const locale = document.documentElement.lang;
const noteCountFormat = new Intl.NumberFormat(locale);

let noReblogMenu;

export const styleElement = buildStyle(`
${postOwnerControlsSelector} {
position: relative;
Expand Down Expand Up @@ -127,6 +129,7 @@ const onNoteCountClick = (event) => {

const processPosts = (postElements) => postElements.forEach(async postElement => {
postElement.querySelector(`.${noteCountClass}`)?.remove();
postElement.querySelector(`.${reblogLinkClass}`)?.remove();

const { noteCount } = await timelineObject(postElement);
const noteCountButton = button({ class: noteCountClass, click: onNoteCountClick }, [
Expand All @@ -135,6 +138,10 @@ const processPosts = (postElements) => postElements.forEach(async postElement =>

const engagementControls = postElement.querySelector(engagementControlsSelector);
engagementControls?.before(noteCountButton);

if (noReblogMenu) {
processReblogButton(engagementControls?.querySelector(reblogButtonSelector));
}
});

const getReblogMenuItem = async (reblogButton, href) => {
Expand Down Expand Up @@ -174,13 +181,10 @@ const onReblogLinkClick = (event) => {
getReblogMenuItem(reblogButton, href).then(reblogMenuItem => reblogMenuItem.click());
};

const processReblogButtons = (reblogButtons) => reblogButtons.forEach(async reblogButton => {
const { blogName, canReblog, idString, reblogKey } = await timelineObject(reblogButton);

if (reblogButton.matches(`.${reblogLinkClass} ~ :scope`)) {
$(reblogButton).siblings(`.${reblogLinkClass}`).remove();
}
const processReblogButton = async reblogButton => {
if (!reblogButton) return;

const { blogName, canReblog, idString, reblogKey } = await timelineObject(reblogButton);
if (!canReblog) return;

const styleContent = `${reblogMenuPortalSelector}:has([aria-labelledby="${reblogButton.id}"]) { display: none; }`;
Expand All @@ -196,33 +200,27 @@ const processReblogButtons = (reblogButtons) => reblogButtons.forEach(async rebl
);

reblogButton.before(reblogLink);
});

const restoreReblogButtons = () => {
pageModifications.unregister(processReblogButtons);
$(`.${reblogLinkClass}`).remove();
};

export const onStorageChanged = async function (changes) {
const { 'classic_footer.preferences.noReblogMenu': noReblogMenuChanges } = changes;
if (noReblogMenuChanges && noReblogMenuChanges.oldValue === undefined) return;
const {
'classic_footer.preferences.noReblogMenu': noReblogMenuChanges
} = changes;

const { newValue: noReblogMenu } = noReblogMenuChanges;
noReblogMenu
? pageModifications.register(reblogButtonSelector, processReblogButtons)
: restoreReblogButtons();
if (noReblogMenuChanges && noReblogMenuChanges.oldValue !== undefined) {
({ newValue: noReblogMenu } = noReblogMenuChanges);
pageModifications.trigger(processPosts);
}
};

export const main = async function () {
pageModifications.register(`${postOrRadarSelector} article`, processPosts);
({ noReblogMenu } = await getPreferences('classic_footer'));

const { noReblogMenu } = await getPreferences('classic_footer');
if (noReblogMenu) pageModifications.register(reblogButtonSelector, processReblogButtons);
pageModifications.register(`${postOrRadarSelector} article`, processPosts);
};

export const clean = async function () {
pageModifications.unregister(processPosts);
$(`.${noteCountClass}`).remove();

restoreReblogButtons();
$(`.${reblogLinkClass}`).remove();
};