refactor(Classic Footer): Combine noReblogMenu link addition with main code #1968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcustyphoon
deleted the
marcustyphoon/classic-footer-reblog-link-refactor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a surprise tool that can help us later.
Description
Rather than registering a separate pageModifications function to implement the "Turn reblog buttons back into links" option in Classic Footer, this does the necessary changes in the same function. This will be useful if we have to modify the Classic Footer lifecycle for future compatibility.
Preference changes are implemented by triggering the same function again, with cleanup added to the function.
Also resolves #1944 (I think? I copied the
onStorageChangedcode from Vanilla Video).Testing steps
Expect no functional changes. todo: write this section.