Quick Reblog: Fix popup on accounts with new footer variant

[marcustyphoon]

Description

This fixes an issue on a new slight variant of one of the post footers that's floating around where clicks within the quick reblog popup would trigger the reblog button and open the reblog interface. the Quick Reblog popup wouldn't appear when hovering over the reblog button.

Resolves #1822.

Testing steps

On all 3 footer variations:

• Confirm that the Quick Reblog modal appears when hovering over the reblog button.
• Confirm that the Quick Reblog modal doesn't appear when hovering over the reblog button of a post with reblogs disabled.
• Confirm that clicking the blog selector, text boxes, quick tags buttons, and submit buttons in the Quick Reblog modal only do what they're supposed to.
• Confirm that the Quick Reblog modal functions.
• Confirm that the reblog button changes color when Quick Reblog is used to reblog a post.

Note that the reblog button will become highlighted when mousing over the Quick Reblog popup in one split notes variant but not the other.

[AprilSylph]

• No-features variant
  • Confirm that the Quick Reblog modal appears when hovering over the reblog button.
  • Confirm that the Quick Reblog modal doesn't appear when hovering over the reblog button of a post with reblogs disabled.
  • Confirm that clicking the blog selector, text boxes, quick tags buttons, and submit buttons in the Quick Reblog modal only do what they're supposed to.
  • Confirm that the Quick Reblog modal functions.
  • Confirm that the reblog button changes color when Quick Reblog is used to reblog a post.
• postFooterSplitNotesCount
  • Confirm that the Quick Reblog modal appears when hovering over the reblog button.
  • Confirm that the Quick Reblog modal doesn't appear when hovering over the reblog button of a post with reblogs disabled.
  • Confirm that clicking the blog selector, text boxes, quick tags buttons, and submit buttons in the Quick Reblog modal only do what they're supposed to.
  • Confirm that the Quick Reblog modal functions.
  • Confirm that the reblog button changes color when Quick Reblog is used to reblog a post.
• postFooterSplitNotesCountSingleAction
  • Confirm that the Quick Reblog modal appears when hovering over the reblog button.
  • Confirm that the Quick Reblog modal doesn't appear when hovering over the reblog button of a post with reblogs disabled.
  • Confirm that clicking the blog selector, text boxes, quick tags buttons, and submit buttons in the Quick Reblog modal only do what they're supposed to.
  • Confirm that the Quick Reblog modal functions.
  • Confirm that the reblog button changes color when Quick Reblog is used to reblog a post.

---

Confirm that the Quick Reblog modal doesn't appear when hovering over the reblog button of a post with reblogs disabled.

In the postFooterSplitNotesCountSingleAction variant, the reblog button is not disabled; instead, the popup that appears when clicking it has no reblog options, just "See reblogs" to open the notes. As a result, our code has no idea that it shouldn't show a Quick Reblog modal on the button. I guess we have to test the React data instead of relying on disabled/aria-disabled now? :ugh:

[marcustyphoon]

Oh, right, I discovered this but forgot that it would have implications for this PR: there's different behavior for "reblogs disabled; has no reblogs" (disabled button) and "reblogs disabled; has reblogs" (button is enabled and only links to the reblogs).

[marcustyphoon]

Checking canReblog on the post mostly works, but posts on a password-protected blog are not rebloggable but have that value set to true. Checking for isPasswordProtected on the blog as well should fix this. If we do this, we should make it an export of src/utils/react_props.js.

Edit: Hah, no, it doesn't fix this, because isPasswordProtected doesn't exist on posts in peepr, because it's not queried... which also breaks Tumblr's reblog button disabling functionality. Sending this to support.

Not sure if there's another way yet.

[marcustyphoon]

On all 3 footer variations:

• Confirm that the Quick Reblog modal doesn't appear when hovering over the reblog button of a post with reblogs disabled that has never been reblogged.
• Confirm that the Quick Reblog modal doesn't appear when hovering over the reblog button of a post with reblogs disabled but that has been reblogged before and thus has a reblog/note count.

Note that the Quick Reblog modal doesn't appear when hovering over the reblog button of a post on a password-protected blog on the "channel" page, but does appear when doing so in the blog view modal and will 404 when used. This is a Tumblr bug, as the native reblog button will also be enabled and will also show an error message when clicked in this case.

[AprilSylph]

• No features variant
  • Confirm that the Quick Reblog modal doesn't appear when hovering over the reblog button of a post with reblogs disabled that has never been reblogged.
  • Confirm that the Quick Reblog modal doesn't appear when hovering over the reblog button of a post with reblogs disabled but that has been reblogged before and thus has a reblog/note count.
• postFooterSplitNotesCount
  • Confirm that the Quick Reblog modal doesn't appear when hovering over the reblog button of a post with reblogs disabled that has never been reblogged.
  • Confirm that the Quick Reblog modal doesn't appear when hovering over the reblog button of a post with reblogs disabled but that has been reblogged before and thus has a reblog/note count.
• postFooterSplitNotesCountSingleAction
  • Confirm that the Quick Reblog modal doesn't appear when hovering over the reblog button of a post with reblogs disabled that has never been reblogged.
  • Confirm that the Quick Reblog modal doesn't appear when hovering over the reblog button of a post with reblogs disabled but that has been reblogged before and thus has a reblog/note count.