Quick Reblog: Feature nonfunctional on accounts with a new footer variant

[marcustyphoon]

Platform

MacOS 14.7.6 arm64

Browser

Chrome 137.0.7151.104

Addon version

master branch

Details

I was working on fixing an issue yesterday in which the quick reblog popup was somewhat buggy on the new alternative split-notes post footer (clicks in it would also click the button; fixable with preventDefault()), but doing it correctly (fixing the insertion location in the DOM) wound up being more complicated than I thought, and today the code changed again and now the feature in its current state is nonfunctional. Still looking into it; I'll file the bug in case you want to as well/since it might take long enough to justify that.

[marcustyphoon]

ohhh my god jquery doesn't support :has(). fun.

anyway, for reference. current post footer:

<footer aria-label="Post Footer" class="tOKgq • 📝footer-23" role="contentinfo">
  <div class="m5KTc • 📝footerRow">
    /* note count */
    <div class="MCavR • 📝controls-19">
      /* share button */ /* reply button */
      <div class="sfGru • 📝controlIcon-6">
        /* bubbles */
        <span class="BPf9u • 📝targetWrapper-2" data-testid="controlled-popover-wrapper">
          <span class="BPf9u • 📝targetWrapper-2">
            <span
              class="Vcrhu • 📝targetWrapperFlex"
              data-testid="controlled-popover-wrapper"
              style="height: 100%"
            >
              <span class="Vcrhu • 📝targetWrapperFlex">
                <a aria-label="Reblog" class="fvSXi • 📝link-18" href="/reblog/[etc]" role="button">
                  /* */
                </a>
              </span>
            </span>
          </span>
          /* tooltip */
        </span>
        <div id="quick-reblog" class="above •">/* */</div>
      </div>
      /* likes button */
    </div>
  </div>
  <div class="yTb5J • 📝postActivityWrapper"></div>
</footer>

split notes:

<footer aria-label="Post footer" class="ESQx2 • 📝postFooter-2">
  <div class="QF8_K • 📝footerContent-3">
    <div class="IivJ4 • 📝engagementControls-2">
      /* reply button */
      <div class="YeSqs • 📝engagementCountWrapper">
        <div class="RTLvY BXwrP lAUpb • 📝footerControl 📝reblogsControl 📝withControlTargetStyles">
          <div class="pIKFz • 📝engagementAction-2">
            <span class="Vcrhu • 📝targetWrapperFlex" data-testid="controlled-popover-wrapper">
              <span class="Vcrhu • 📝targetWrapperFlex">
                <a
                  aria-disabled="false"
                  class="VmbqY r21y5 Li_00 ndGZ1 b067h • 📝button-64 📝content-62 📝sizeMedium-2 📝action-6 📝brandGreen-4"
                  aria-label="Reblog"
                  href="/reblog/[etc]"
                >
                  /* */
                </a>
                /* tooltip; bubbles */
              </span>
            </span>
            <div id="quick-reblog" class="above •">/* */</div>
          </div>
          <button
            aria-label="41 reblogs"
            class="HqbFo WLI6w • 📝reblogCount 📝engagementCount"
            tabindex="0"
          >
            41
          </button>
        </div>
      </div>
      /* likes button */
    </div>
    <div>/* share button */</div>
  </div>
  <div class="XSoPc • 📝postActivity-2"></div>
</footer>

split notes, new variant:

<footer aria-label="Post footer" class="_Krz6 • 📝postFooter-2">
  <div class="IBIxS • 📝footerContent-3">
    <div class="fPlC8 • 📝engagementControls-2">
      /* reply button */
      <span class="Vcrhu • 📝targetWrapperFlex" data-testid="controlled-popover-wrapper">
        <span class="Vcrhu • 📝targetWrapperFlex">
          <button
            aria-disabled="false"
            class="VmbqY r21y5 Li_00 jpQn0 b067h • 📝button-64 📝content-62 📝sizeMedium-2 📝engagementAction-2 📝brandGreen-4"
            aria-label="Reblog"
            aria-expanded="false"
            aria-haspopup="menu"
            id=":r17a:"
            aria-controls=":r17b:"
            type="button"
          >
            <span class="IXkOE • 📝icon-33">
              <svg height="24" role="presentation" width="24" xmlns="http://www.w3.org/2000/svg">
                <use href="#managed-icon__ds-reblog-24"></use>
              </svg>
            </span>
            <span class="Kv19n • 📝engagementCount-2"><span class="•">38</span></span>
          </button>
          /* bubbles */
        </span>
      </span>
      /* likes button */
    </div>
    <div>/* share button */</div>
  </div>
  <div class="eh8he • 📝postActivity-2"></div>
</footer>

split notes, new variant, from yesterday; ignore this one:

<footer aria-label="Post footer" class="_Krz6 • 📝postFooter-2">
  <div class="IBIxS • 📝footerContent-3">
    <div class="fPlC8 • 📝engagementControls-2">
      /* reply button */
      <span class="Vcrhu • 📝targetWrapperFlex" data-testid="controlled-popover-wrapper">
        <span class="Vcrhu • 📝targetWrapperFlex">
          <a
            aria-disabled="false"
            class="VmbqY r21y5 Li_00 jpQn0 b067h • 📝button-64 📝content-62 📝sizeMedium-2 📝engagementAction-2 📝brandGreen-4"
            aria-label="Reblog"
            href="/reblog/[etc]"
          >
            /* */
          </a>
          /* tooltip; bubbles */
        </span>
        <div id="quick-reblog" class="above •">/* */</div>
      </span>
      /* likes button */
    </div>
    <div>/* share button */</div>
  </div>
  <div class="eh8he • 📝postActivity-2"></div>
</footer>

[marcustyphoon]

Split-notes-new-variant button currently has no aria label in Hindi, Indonesian, or Chinese (3 dialects).