Skip to content

Conversation

@martintmk
Copy link
Contributor

@martintmk martintmk commented Jun 19, 2023

Details on the issue fix or feature implementation

These are used to track execution attempts in retries and hedging.

Closes #1308

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jun 19, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jun 19, 2023
@martintmk martintmk force-pushed the mtomka/enhance-telemetry-and-args branch from 3d669cd to dbc1896 Compare June 19, 2023 13:12
@martintmk martintmk force-pushed the mtomka/enhance-telemetry-and-args branch from dbc1896 to d380d8c Compare June 19, 2023 13:15
@martintmk martintmk force-pushed the mtomka/enhance-telemetry-and-args branch from 74238bf to 79aee91 Compare June 20, 2023 06:13
@martintmk martintmk marked this pull request as ready for review June 20, 2023 06:13
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #1326 (f2801b1) into main (91e5384) will increase coverage by 0.17%.
The diff coverage is 100.00%.

❗ Current head f2801b1 differs from pull request most recent head 30a31ea. Consider uploading reports for the commit 30a31ea to get more accurate results

@@            Coverage Diff             @@
##             main    #1326      +/-   ##
==========================================
+ Coverage   83.49%   83.67%   +0.17%     
==========================================
  Files         269      270       +1     
  Lines        6379     6449      +70     
  Branches     1004     1010       +6     
==========================================
+ Hits         5326     5396      +70     
  Misses        844      844              
  Partials      209      209              
Flag Coverage Δ
linux ?
macos 83.67% <100.00%> (+0.17%) ⬆️
windows 83.67% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...xtensions/Telemetry/TelemetryResilienceStrategy.cs 100.00% <ø> (ø)
...ry/TelemetryResilienceStrategyBuilderExtensions.cs 100.00% <ø> (ø)
...Polly.Core/Hedging/Controller/HedgingController.cs 100.00% <100.00%> (ø)
src/Polly.Core/Hedging/Controller/TaskExecution.cs 100.00% <100.00%> (ø)
...rc/Polly.Core/Hedging/HedgingResilienceStrategy.cs 100.00% <100.00%> (ø)
src/Polly.Core/Hedging/OnHedgingArguments.cs 100.00% <100.00%> (ø)
src/Polly.Core/Retry/OnRetryArguments.cs 100.00% <100.00%> (ø)
src/Polly.Core/Retry/RetryResilienceStrategy.cs 100.00% <100.00%> (ø)
...y.Core/Telemetry/ExecutionAttemptArguments.Pool.cs 100.00% <100.00%> (ø)
.../Polly.Core/Telemetry/ExecutionAttemptArguments.cs 100.00% <100.00%> (ø)
... and 4 more

... and 1 file with indirect coverage changes

@martintmk martintmk enabled auto-merge (squash) June 20, 2023 07:05
@martintmk martintmk merged commit 47aef87 into main Jun 20, 2023
@martintmk martintmk deleted the mtomka/enhance-telemetry-and-args branch June 20, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v8 Issues related to the new version 8 of the Polly library.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Track execution time for retries and hedging attempts

2 participants