API feedback (#1327)

Author: martintmk

bench/Polly.Core.Benchmarks/ResilienceStrategyProviderBenchmark.cs

@@ -17,8 +17,8 @@ public void Setup()
     }
 
     [Benchmark]
-    public void Get_Ok() => _provider!.Get("dummy");
+    public void Get_Ok() => _provider!.GetStrategy("dummy");
 
     [Benchmark]
-    public void Get_Generic_Ok() => _provider!.Get<string>("dummy");
+    public void Get_Generic_Ok() => _provider!.GetStrategy<string>("dummy");
 }

bench/Polly.Core.Benchmarks/TelemetryBenchmark.cs

@@ -61,7 +61,7 @@ private ResilienceStrategy Build(ResilienceStrategyBuilder builder)
                 });
             }
 
-            builder.EnableTelemetry(options);
+            builder.ConfigureTelemetry(options);
         }
 
         return builder.Build();

bench/Polly.Core.Benchmarks/Utils/Helper.MultipleStrategies.cs

@@ -44,7 +44,7 @@ internal static partial class Helper
 
             if (telemetry)
             {
-                builder.EnableTelemetry(NullLoggerFactory.Instance);
+                builder.ConfigureTelemetry(NullLoggerFactory.Instance);
             }
         }),
         _ => throw new NotSupportedException()

samples/GenericStrategies/Program.cs

@@ -66,7 +66,7 @@
 var response = await strategy.ExecuteAsync(
     async token =>
     {
-        await Task.Delay(10);
+        await Task.Delay(10, token);
         // This causes the action fail, thus using the fallback strategy above
         return new HttpResponseMessage(HttpStatusCode.InternalServerError);
     },

samples/Intro/Program.cs

@@ -22,13 +22,13 @@
 strategy.Execute(() => { });
 
 // Asynchronously
-await strategy.ExecuteAsync(async token => { await Task.Delay(10); }, CancellationToken.None);
+await strategy.ExecuteAsync(async token => { await Task.Delay(10, token); }, CancellationToken.None);
 
 // Synchronously with result
 strategy.Execute(token => "some-result");
 
 // Asynchronously with result
-await strategy.ExecuteAsync(async token => { await Task.Delay(10); return "some-result"; }, CancellationToken.None);
+await strategy.ExecuteAsync(async token => { await Task.Delay(10, token); return "some-result"; }, CancellationToken.None);
 
 // Use state to avoid lambda allocation
 strategy.Execute(static state => state, "my-state");

src/Polly.Core/CircuitBreaker/CircuitBreakerResilienceStrategyBuilderExtensions.cs

@@ -102,7 +102,7 @@ public static ResilienceStrategyBuilder AddSimpleCircuitBreaker(this ResilienceS
     private static TBuilder AddAdvancedCircuitBreakerCore<TBuilder, TResult>(this TBuilder builder, AdvancedCircuitBreakerStrategyOptions<TResult> options)
         where TBuilder : ResilienceStrategyBuilderBase
     {
-        builder.AddStrategy(
+        return builder.AddStrategy(
             context =>
             {
                 var behavior = new AdvancedCircuitBehavior(
@@ -113,15 +113,12 @@ private static TBuilder AddAdvancedCircuitBreakerCore<TBuilder, TResult>(this TB
                 return CreateStrategy(context, options, behavior);
             },
             options);
-
-        return builder;
     }
 
     private static TBuilder AddSimpleCircuitBreakerCore<TBuilder, TResult>(this TBuilder builder, SimpleCircuitBreakerStrategyOptions<TResult> options)
         where TBuilder : ResilienceStrategyBuilderBase
     {
-        builder.AddStrategy(context => CreateStrategy(context, options, new ConsecutiveFailuresCircuitBehavior(options.FailureThreshold)), options);
-        return builder;
+        return builder.AddStrategy(context => CreateStrategy(context, options, new ConsecutiveFailuresCircuitBehavior(options.FailureThreshold)), options);
     }
 
     internal static CircuitBreakerResilienceStrategy CreateStrategy<TResult>(ResilienceStrategyBuilderContext context, CircuitBreakerStrategyOptions<TResult> options, CircuitBehavior behavior)

src/Polly.Core/Registry/ResilienceStrategyProvider.cs

@@ -17,9 +17,9 @@ public abstract class ResilienceStrategyProvider<TKey>
     /// <param name="key">The key used to identify the resilience strategy.</param>
     /// <returns>The resilience strategy associated with the specified key.</returns>
     /// <exception cref="KeyNotFoundException">Thrown when no resilience strategy is found for the specified key.</exception>
-    public virtual ResilienceStrategy Get(TKey key)
+    public virtual ResilienceStrategy GetStrategy(TKey key)
     {
-        if (TryGet(key, out var strategy))
+        if (TryGetStrategy(key, out var strategy))
         {
             return strategy;
         }
@@ -35,9 +35,9 @@ public virtual ResilienceStrategy Get(TKey key)
     /// <param name="key">The key used to identify the resilience strategy.</param>
     /// <returns>The resilience strategy associated with the specified key.</returns>
     /// <exception cref="KeyNotFoundException">Thrown when no resilience strategy is found for the specified key.</exception>
-    public virtual ResilienceStrategy<TResult> Get<TResult>(TKey key)
+    public virtual ResilienceStrategy<TResult> GetStrategy<TResult>(TKey key)
     {
-        if (TryGet<TResult>(key, out var strategy))
+        if (TryGetStrategy<TResult>(key, out var strategy))
         {
             return strategy;
         }
@@ -52,7 +52,7 @@ public virtual ResilienceStrategy<TResult> Get<TResult>(TKey key)
     /// <param name="key">The key used to identify the resilience strategy.</param>
     /// <param name="strategy">The output resilience strategy if found, <see langword="null"/> otherwise.</param>
     /// <returns><see langword="true"/> if the strategy was found, <see langword="false"/> otherwise.</returns>
-    public abstract bool TryGet(TKey key, [NotNullWhen(true)] out ResilienceStrategy? strategy);
+    public abstract bool TryGetStrategy(TKey key, [NotNullWhen(true)] out ResilienceStrategy? strategy);
 
     /// <summary>
     /// Tries to get a generic resilience strategy from the provider using the specified key.
@@ -61,5 +61,5 @@ public virtual ResilienceStrategy<TResult> Get<TResult>(TKey key)
     /// <param name="key">The key used to identify the resilience strategy.</param>
     /// <param name="strategy">The output resilience strategy if found, <see langword="null"/> otherwise.</param>
     /// <returns><see langword="true"/> if the strategy was found, <see langword="false"/> otherwise.</returns>
-    public abstract bool TryGet<TResult>(TKey key, [NotNullWhen(true)] out ResilienceStrategy<TResult>? strategy);
+    public abstract bool TryGetStrategy<TResult>(TKey key, [NotNullWhen(true)] out ResilienceStrategy<TResult>? strategy);
 }

src/Polly.Core/Registry/ResilienceStrategyRegistry.cs

@@ -65,7 +65,7 @@ public ResilienceStrategyRegistry(ResilienceStrategyRegistryOptions<TKey> option
     /// <param name="strategy">The resilience strategy instance.</param>
     /// <returns><see langword="true"/> if the strategy was added successfully, <see langword="false"/> otherwise.</returns>
     /// <exception cref="ArgumentNullException">Thrown when <paramref name="strategy"/> is <see langword="null"/>.</exception>
-    public bool TryAdd(TKey key, ResilienceStrategy strategy)
+    public bool TryAddStrategy(TKey key, ResilienceStrategy strategy)
     {
         Guard.NotNull(strategy);
 
@@ -80,7 +80,7 @@ public bool TryAdd(TKey key, ResilienceStrategy strategy)
     /// <param name="strategy">The resilience strategy instance.</param>
     /// <returns><see langword="true"/> if the strategy was added successfully, <see langword="false"/> otherwise.</returns>
     /// <exception cref="ArgumentNullException">Thrown when <paramref name="strategy"/> is <see langword="null"/>.</exception>
-    public bool TryAdd<TResult>(TKey key, ResilienceStrategy<TResult> strategy)
+    public bool TryAddStrategy<TResult>(TKey key, ResilienceStrategy<TResult> strategy)
     {
         Guard.NotNull(strategy);
 
@@ -92,24 +92,24 @@ public bool TryAdd<TResult>(TKey key, ResilienceStrategy<TResult> strategy)
     /// </summary>
     /// <param name="key">The key used to identify the resilience strategy.</param>
     /// <returns><see langword="true"/> if the strategy was removed successfully, <see langword="false"/> otherwise.</returns>
-    public bool Remove(TKey key) => _strategies.TryRemove(key, out _);
+    public bool RemoveStrategy(TKey key) => _strategies.TryRemove(key, out _);
 
     /// <summary>
     /// Removes a generic resilience strategy from the registry.
     /// </summary>
     /// <typeparam name="TResult">The type of result that the resilience strategy handles.</typeparam>
     /// <param name="key">The key used to identify the resilience strategy.</param>
     /// <returns><see langword="true"/> if the strategy was removed successfully, <see langword="false"/> otherwise.</returns>
-    public bool Remove<TResult>(TKey key) => GetGenericRegistry<TResult>().Remove(key);
+    public bool RemoveStrategy<TResult>(TKey key) => GetGenericRegistry<TResult>().Remove(key);
 
     /// <inheritdoc/>
-    public override bool TryGet<TResult>(TKey key, [NotNullWhen(true)] out ResilienceStrategy<TResult>? strategy)
+    public override bool TryGetStrategy<TResult>(TKey key, [NotNullWhen(true)] out ResilienceStrategy<TResult>? strategy)
     {
         return GetGenericRegistry<TResult>().TryGet(key, out strategy);
     }
 
     /// <inheritdoc/>
-    public override bool TryGet(TKey key, [NotNullWhen(true)] out ResilienceStrategy? strategy)
+    public override bool TryGetStrategy(TKey key, [NotNullWhen(true)] out ResilienceStrategy? strategy)
     {
         if (_strategies.TryGetValue(key, out strategy))
         {
@@ -192,7 +192,7 @@ public bool TryAddBuilder<TResult>(TKey key, Action<ResilienceStrategyBuilder<TR
     /// <remarks>
     /// This method only clears the cached strategies, the registered builders are kept unchanged.
     /// </remarks>
-    public void Clear() => _strategies.Clear();
+    public void ClearStrategies() => _strategies.Clear();
 
     /// <summary>
     /// Clears all cached generic strategies.
@@ -201,7 +201,7 @@ public bool TryAddBuilder<TResult>(TKey key, Action<ResilienceStrategyBuilder<TR
     /// <remarks>
     /// This method only clears the cached strategies, the registered builders are kept unchanged.
     /// </remarks>
-    public void Clear<TResult>() => GetGenericRegistry<TResult>().Clear();
+    public void ClearStrategies<TResult>() => GetGenericRegistry<TResult>().Clear();
 
     private static ResilienceStrategy CreateStrategy<TBuilder>(
         Func<TBuilder> activator,

src/Polly.Core/ResilienceStrategyBuilderBase.cs

@@ -72,15 +72,7 @@ private protected ResilienceStrategyBuilderBase(ResilienceStrategyBuilderBase ot
 
     internal abstract bool IsGenericBuilder { get; }
 
-    /// <summary>
-    /// Adds a strategy to the builder.
-    /// </summary>
-    /// <param name="factory">The factory that creates a resilience strategy.</param>
-    /// <param name="options">The options associated with the strategy. If none are provided the default instance of <see cref="ResilienceStrategyOptions"/> is created.</param>
-    /// <exception cref="ArgumentNullException">Thrown when <paramref name="factory"/> is null.</exception>
-    /// <exception cref="InvalidOperationException">Thrown when this builder was already used to create a strategy. The builder cannot be modified after it has been used.</exception>
-    /// <exception cref="ValidationException">Thrown when the <paramref name="options"/> are invalid.</exception>
-    public void AddStrategy(Func<ResilienceStrategyBuilderContext, ResilienceStrategy> factory, ResilienceStrategyOptions options)
+    internal void AddStrategyCore(Func<ResilienceStrategyBuilderContext, ResilienceStrategy> factory, ResilienceStrategyOptions options)
     {
         Guard.NotNull(factory);
         Guard.NotNull(options);

src/Polly.Core/ResilienceStrategyBuilderExtensions.cs

@@ -1,3 +1,5 @@
+using System.ComponentModel.DataAnnotations;
+
 namespace Polly;
 
 /// <summary>
@@ -20,7 +22,28 @@ public static TBuilder AddStrategy<TBuilder>(this TBuilder builder, ResilienceSt
         Guard.NotNull(builder);
         Guard.NotNull(strategy);
 
-        builder.AddStrategy(_ => strategy, EmptyOptions.Instance);
+        return builder.AddStrategy(_ => strategy, EmptyOptions.Instance);
+    }
+
+    /// <summary>
+    /// Adds a strategy to the builder.
+    /// </summary>
+    /// <typeparam name="TBuilder">The builder type.</typeparam>
+    /// <param name="builder">The builder instance.</param>
+    /// <param name="factory">The factory that creates a resilience strategy.</param>
+    /// <param name="options">The options associated with the strategy. If none are provided the default instance of <see cref="ResilienceStrategyOptions"/> is created.</param>
+    /// <returns>The same builder instance.</returns>
+    /// <exception cref="ArgumentNullException">Thrown when <paramref name="builder"/>, <paramref name="factory"/> or <paramref name="options"/> is <see langword="null"/>.</exception>
+    /// <exception cref="InvalidOperationException">Thrown when this builder was already used to create a strategy. The builder cannot be modified after it has been used.</exception>
+    /// <exception cref="ValidationException">Thrown when <paramref name="options"/> is invalid.</exception>
+    public static TBuilder AddStrategy<TBuilder>(this TBuilder builder, Func<ResilienceStrategyBuilderContext, ResilienceStrategy> factory, ResilienceStrategyOptions options)
+        where TBuilder : ResilienceStrategyBuilderBase
+    {
+        Guard.NotNull(builder);
+        Guard.NotNull(factory);
+        Guard.NotNull(options);
+
+        builder.AddStrategyCore(factory, options);
         return builder;
     }