Fix nonudt functions return #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since we already handle receiver, we can remove great part of this function ;-)
replace enigmatic outArg type with ArugmentWrapperData; rewrite argument_wrapper.go to use it immadinatly
this change allows to split function body into variable deffinitions and finisher that should be called after C call. generateFuncBody function now returns a list of string of (mentioned above) variables and finishers instead of instatnly writting them into stringsBuilder. This solution allows me to fix AllenDang#89 by simply calling finisher of output argument just before return statement so that it becomes updated correctly and pointer's value is valid
- get rid of defers when unnecessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.