Skip to content

Conversation

@gucio321
Copy link
Collaborator

@gucio321 gucio321 commented Dec 3, 2022

This reverts commit 47f2614, reversing changes made to c489688.

@gucio321
Copy link
Collaborator Author

gucio321 commented Dec 3, 2022

sadly, its rather not a perfect way to fix the issue 😄
let me think

@eliasdaler
Copy link
Contributor

Let's not jump here, the work done here is good. We might fix it better.

@gucio321
Copy link
Collaborator Author

gucio321 commented Dec 3, 2022

I also wouldn't feel like having this pr merged
I've just opened it because clicking "revert" on #18 didn't work

Go ahead, close this and move discussion to #43

@gucio321 gucio321 closed this Dec 3, 2022
@gucio321 gucio321 deleted the revert-18 branch December 3, 2022 18:50
@gucio321 gucio321 restored the revert-18 branch December 10, 2022 09:52
@gucio321
Copy link
Collaborator Author

I feel terrible about it, but IMO it is the best solution of #43 for now 😢

@gucio321 gucio321 reopened this Dec 10, 2022
Copy link
Contributor

@eliasdaler eliasdaler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, what can you do... "go get" doesn't fetch git submodules so we have no choice here.

@eliasdaler eliasdaler merged commit 51f76d6 into AllenDang:main Dec 10, 2022
@gucio321
Copy link
Collaborator Author

Well, what can you do... "go get" doesn't fetch git submodules so we have no choice here.

@eliasdaler in fact, go get does, but go mod vendor removes them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants