-
Notifications
You must be signed in to change notification settings - Fork 66
Trim ImGui/Im prefixes from Dear ImGui enums #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Any thoughts on this? |
|
@eliasdaler May I ask you as collaborator of this project? Sent the invitation to you. |
|
@eliasdaler Do you have time to create a pull request rule which will make sure every pull request at least could be built? |
Yes. Thank you.
Sure, will try to do it later this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few small points.
|
and there are conflicts |
|
oh, @eliasdaler after merging #46 there are no more conflicts here! |
|
I'll get to this PR a bit later. |
|
ok, thank you! |
|
Okay, turns out trimming of ImPlot's "Im" prefix was needed after all... (because it conflicted with C function names) |
gucio321
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
I disabled trimming for implot due to ImGuiAxis/ImAxis clash (and also had some problems with some other things related to implot). Will try to do the same for implot after moving it to "implot" package later.
I thought about getting rid of prefixes somewhere on C++ generation stage, but I'd say it'll be harder to understand. Right now I needed some stuff in gengo which felt like hacks sometimes, but I think it's okay.
I might do the same for structs, but I'll think about it - it might take a bit more work to do because there's more code which references struct types.