Skip to content

Conversation

@eliasdaler
Copy link
Contributor

@eliasdaler eliasdaler commented Oct 31, 2022

I disabled trimming for implot due to ImGuiAxis/ImAxis clash (and also had some problems with some other things related to implot). Will try to do the same for implot after moving it to "implot" package later.

I thought about getting rid of prefixes somewhere on C++ generation stage, but I'd say it'll be harder to understand. Right now I needed some stuff in gengo which felt like hacks sometimes, but I think it's okay.

I might do the same for structs, but I'll think about it - it might take a bit more work to do because there's more code which references struct types.

@eliasdaler
Copy link
Contributor Author

Any thoughts on this?

@AllenDang
Copy link
Owner

@eliasdaler May I ask you as collaborator of this project? Sent the invitation to you.

@AllenDang
Copy link
Owner

@eliasdaler Do you have time to create a pull request rule which will make sure every pull request at least could be built?

@eliasdaler
Copy link
Contributor Author

eliasdaler commented Nov 8, 2022

May I ask you as collaborator of this project? Sent the invitation to you.

Yes. Thank you.

Do you have time to create a pull request rule which will make sure every pull request at least could be built?

Sure, will try to do it later this week.

Copy link
Collaborator

@gucio321 gucio321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few small points.

@gucio321
Copy link
Collaborator

gucio321 commented Dec 3, 2022

and there are conflicts

@gucio321
Copy link
Collaborator

oh, @eliasdaler after merging #46 there are no more conflicts here!

@eliasdaler
Copy link
Contributor Author

I'll get to this PR a bit later.

@gucio321
Copy link
Collaborator

ok, thank you!
I'm looking forward to see this PR merged! It'll radically chang (and enhance) API and I need it for AllenDang/giu#628 😄

@eliasdaler
Copy link
Contributor Author

Okay, turns out trimming of ImPlot's "Im" prefix was needed after all... (because it conflicted with C function names)
@gucio321, please review again.

Copy link
Collaborator

@gucio321 gucio321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@eliasdaler eliasdaler merged commit 12c2785 into AllenDang:main Dec 13, 2022
@eliasdaler eliasdaler deleted the no_prefixes branch December 13, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants