Remove duplicate cmake dependency from skbuild plugin #1958
Conversation
Remove the duplicate `cmake` dependency that was added by `openexr_skbuild_plugin.py`. Scikit-build-core is adding a dependency on CMake if necessary itself, and adding one unconditionally has a side effect of installing a local PyPI version of CMake that overrides the system CMake that scikit-build-core would be using instead. This can be particularly problematic when downstream patching of CMake is required on the system in question. Fixes AcademySoftwareFoundation#1957 Signed-off-by: Michał Górny <[email protected]>
|
|
I don't seem to be able to sign the CLA since both EasyCLA and Linux Foundation's support system are both throwing internal server errors. |
|
That's odd about the EasyCLA and LF support, could you possibly try it again, in case it was a glitch on their end? Thanks! |
|
Yep, still failing. EasyCLA:
Support system:
I'm going to try mailing them. |
|
I filed a LF support ticket but didn't get much help, beyond the suggestion to try a different browser? |
|
Oh, thanks for letting me know, that made me go through some debugging and I've found the problem: I just wished people would actually give useful error messages such as "can't resolve API domain" instead of "internal errors", sigh. |
|
@mgorny, did you get past the EasyCLA error? Are you able to sign the form? Thanks! |
Yes, it's waiting for our CLA manager to approve. |
|
Following up on this again, any progress with the CLA? |
|
I'm sorry this is taking so long. I've pinged the CLA manager. By the way, do you happen to know if EasyCLA somehow updates the status when the CLA is approved? Because I don't see any kind of "recheck" option. |
|
Thanks! I think you can leave a comment on the PR with the text "/easycla", and that will re-trigger the check. If not, there's a "Rerun all checks" button on the "Checks" page of the PR, we can run that once the paperwork is in place. Let me know when it's in. |
|
/easycla |
## Version 3.3.3 (March 23, 2025) Patch release with miscellaneous bug/build/documentation fixes: * 🐛 Fix a bug involving deep tiled images * 🐛 Adjust the clamping on the dwa compression (Issue [1982](AcademySoftwareFoundation/openexr#1982)) * 🐛 Address issues with small exr files and header parse (Issue [1984](AcademySoftwareFoundation/openexr#1984)) * 🐛 Fix crash if user does not provide memory when filling deep framebuffer * 🐛 Fix bad pointer SSE math causing out-of-bounds access * 🐛 Fix potential buffer overwrite with zip data * 🐛 Fix usage of utf-8 filenames for windows * 🐛 Fix regression in reading EXR images on 32bit Windows involving `atomic_compare_exchange_strong` * 🐛 Add checks to avoid using optimizations when inappropriate (Issue [1949](AcademySoftwareFoundation/openexr#1949)) * 🐛 Convert dwa encoder to use algorithm quantize (Issue [1915](AcademySoftwareFoundation/openexr#1915)) * 🐛 Fix incorrect v3 array size validation * 🚀 Add minor huf encode / decode performance optimizations * 🛠️ Add numpy dependency to python wrapper (Issue [1919](AcademySoftwareFoundation/openexr#1919)) * 🛠️ Remove duplicate cmake dependency from skbuild plugin (Issue [1958](AcademySoftwareFoundation/openexr#1958)) * 🛠️ Don't set the library postfix in the cmake cache (Issue [1981](AcademySoftwareFoundation/openexr#1981)) This version also introduces a new tool, `exrmetrics`, a utility to help analyize file i/o times and compression ratios. See [exrmetrics](https://openexr.com/en/latest/bin/exrmetrics.html) for details. This version also officially installs the `exrcheck` utility, formerly built for internal use but not installed. This version also publishes the python bindings for arm64 on Ubuntu and macOS.
Remove the duplicate
cmakedependency that was added byopenexr_skbuild_plugin.py. Scikit-build-core is adding a dependency on CMake if necessary itself, and adding one unconditionally has a side effect of installing a local PyPI version of CMake that overrides the system CMake that scikit-build-core would be using instead. This can be particularly problematic when downstream patching of CMake is required on the system in question.Fixes #1957