Skip to content

Commit 91a2bfe

Browse files
committed
Remove duplicate cmake dependency from skbuild plugin
Remove the duplicate `cmake` dependency that was added by `openexr_skbuild_plugin.py`. Scikit-build-core is adding a dependency on CMake if necessary itself, and adding one unconditionally has a side effect of installing a local PyPI version of CMake that overrides the system CMake that scikit-build-core would be using instead. This can be particularly problematic when downstream patching of CMake is required on the system in question. Fixes #1957 Signed-off-by: Michał Górny <[email protected]>
1 parent 66158f8 commit 91a2bfe

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

src/wrappers/python/openexr_skbuild_plugin.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -99,8 +99,3 @@ def dynamic_metadata(
9999
print("openexr_skbuild_plugin: Computed version: {0}".format(version))
100100

101101
return version
102-
103-
def get_requires_for_dynamic_metadata(
104-
_settings: Optional[Dict[str, object]] = None,
105-
) -> List[str]:
106-
return ["cmake"]

0 commit comments

Comments
 (0)