feat: eliminate performance sensitive #877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. eliminate set performance sensitive = true|false in cli 2. remove related API in C++ sdk and java sdk 3. add enable_request_performance_sensitive in engine option, for ddl gen to get a request physical plan performance-insensitive 4. fix yaml case, online batch queries can be executed performance insensitive
jingchen2222
requested review from
aceforeverd,
dl239,
tobegit3hub and
vagetablechicken
aceforeverd
reviewed
Dec 12, 2021
…minate_performance_sensitive # Conflicts: # hybridse/include/vm/physical_op.h # hybridse/src/vm/physical_op.cc # hybridse/src/vm/transform.cc # hybridse/src/vm/transform_test.cc
Codecov Report
@@ Coverage Diff @@
## main #877 +/- ##
============================================
+ Coverage 42.36% 42.40% +0.03%
Complexity 219 219
============================================
Files 572 572
Lines 105529 105600 +71
Branches 946 946
============================================
+ Hits 44703 44775 +72
+ Misses 60682 60681 -1
Partials 144 144
Continue to review full report at Codecov.
|
|
remember to update the related docs |
DONE |
…at/eliminate_performance_sensitive
…minate_performance_sensitive # Conflicts: # src/cmd/file_option_parser.h
jingchen2222
commented
Dec 21, 2021
aceforeverd
approved these changes
Dec 21, 2021
dl239
approved these changes
Dec 21, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behaviour? (You can also link to an open issue here)
resolve Eliminate the concept of performance-sensitive mode for users #796
What is the new behaviour (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: