feat: support session variables in sql client #933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vagetablechicken
requested review from
aceforeverd,
jingchen2222 and
tobegit3hub
and removed request for
jingchen2222 and
tobegit3hub
tobegit3hub
reviewed
Dec 21, 2021
vagetablechicken
force-pushed
the
issue-714
branch
from
1983130 to
d07ff0e
Compare
aceforeverd
previously requested changes
Dec 21, 2021
dl239
approved these changes
Dec 21, 2021
|
The case |
Codecov Report
@@ Coverage Diff @@
## main #933 +/- ##
============================================
- Coverage 42.51% 42.32% -0.19%
- Complexity 219 220 +1
============================================
Files 565 568 +3
Lines 105537 105994 +457
Branches 936 966 +30
============================================
- Hits 44869 44867 -2
- Misses 60524 60983 +459
Partials 144 144
Continue to review full report at Codecov.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #714
Current CLI session variables: execute_mode, performance_sensitive.
P.S. 'performance_sensitive' will set the value to sql cluster router. 'execute_mode' only supports set/show, no effect.