Make LoadFromWebAsync honor the Timeout property. Fixes #580 #582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cant0r
changed the title
|
Hello @cant0r , Thank you for the pull request. If there is no problem (it doesn't look to have one), I will merge it in 2 weeks when I am back from my vacation. Best Regards, Jon |
|
Hello @cant0r , Thank you for your PR, The code has been merged and released in the version v1.11.73 Best Regards, Jon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was testing out the library's
LoadFromWebAsyncmethods, I noticed that theTimeoutproperty is not registered for the usedHttpClientinstance.I was always thrown a
TaskCanceledExceptionwith the default Microsoft set 100 seconds timeout, I could not even influence it via providing a customPreRequestdelegate.I checked the active issues and I saw someone else also encountered this behavior. #580