Skip to content

Conversation

@lahma
Copy link
Contributor

@lahma lahma commented Jun 30, 2024

  • mark methods static

@JonathanMagnan JonathanMagnan self-assigned this Sep 17, 2025
@JonathanMagnan
Copy link
Member

Hello @lahma ,

Thank you for your contribution ;)

I'm not 100% sure about marking the method static is a good idea or not for an existing method, but let go ahead with this change.

Best Regards,

Jon

@JonathanMagnan JonathanMagnan merged commit 84cea56 into zzzprojects:master Sep 17, 2025
@lahma
Copy link
Contributor Author

lahma commented Sep 17, 2025

Thank you for your contribution ;)

No worries, thank you for accepting them 👍🏻

I'm not 100% sure about marking the method static is a good idea or not for an existing method, but let go ahead with this change.

For private and internal methods it should affect the public API or expectations. .NET API analyzers flags such methods that they should be static so it will help the compiler and runtime to optimize.

@lahma lahma deleted the replace-to-lower branch September 17, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants