actions: Execute possible callbacks on Y/N prompts

[JoeKar]

This will execute the callback also in case the answer was "no", like we did with #3719.

Fixes #3878

[Neko-Box-Coder]

// The callback is only called if the save was successful

I am confused. How does the callback() know if the save happened or not?

This might also affect any plugins that use this function since it is a public function.

[JoeKar]

// The callback is only called if the save was successful

True for SaveAsCB() and saveBufToFile(), but what does it mean when the user cancels the sudo-prompt, because it shouldn't be written that way? The save wasn't even performed then...by user intention...is it then successful or not? 🤔

I am confused. How does the callback() know if the save happened or not?

Right now it can't, since we don't pass any arguments. Maybe we should?

[Neko-Box-Coder]

The save wasn't even performed then...by user intention...is it then successful or not? 🤔

To me, the comment reads as the callback is called only when the save is done successfully, so no it wouldn't count as "successful". It is reflected in the code logic as well.

I am confused. How does the callback() know if the save happened or not?

Right now it can't, since we don't pass any arguments. Maybe we should?

My main gripe is backward compatibility for existing plugins.

Looking at the code now, here's the callstack: Quit() -> SaveCB() -> saveBufToFile() / SaveAsCB()

SaveCB() promises to perform the callback at the end (Which is not atm), but the other two only perform the callback when it is successful.

We can change saveBufToFile() however we want, but can't do so for SaveAsCB().

Maybe we should change saveBufToFile() to have 2 callbacks, one for success and one for failure.
Then we rename SaveAsCB() to saveAsCB() and have the same 2 callbacks.
Finally, we keep the same signature for SaveAsCB() but pass nil for the failure callback to saveAsCB()

This way we can have the ability to always perform a callback without breaking any backward compatibility.

WDYT? @JoeKar

I am not sure about SaveCB() tbh, maybe we can "correct" it back judging the existing code is expecting it to call the callback no matter what at the end.

[JoeKar]

Maybe we should change saveBufToFile() to have 2 callbacks, one for success and one for failure. Then we rename SaveAsCB() to saveAsCB() and have the same 2 callbacks. Finally, we keep the same signature for SaveAsCB() but pass nil for the failure callback to saveAsCB()

This way we can have the ability to always perform a callback without breaking any backward compatibility.

WDYT? @JoeKar

Or saveBufToFile() and saveAsCB() will just use one callback, but with argument. SaveAsCB() can create it locally and call the injected callback depending on its own with the argument (success only). We can stick to the promise defined and exported by SaveAsCB() and thus keep the compatibility.

[Neko-Box-Coder]

Or saveBufToFile() and saveAsCB() will just use one callback, but with argument

Nice, this works as well.