Skip to content

Conversation

@ntotten
Copy link
Member

@ntotten ntotten commented Sep 17, 2025

Adds a new property on the link navigation type that allows specifying a target of either _blank or _self. The property is optional and defaults to _blank

Copilot AI review requested due to automatic review settings September 17, 2025 11:30
@vercel
Copy link

vercel bot commented Sep 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
zudoku-cosmo-cargo Ready Ready Preview Sep 17, 2025 11:31am
zudoku-docs Ready Ready Preview Sep 17, 2025 11:31am

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds customization for link targets in navigation items. It introduces an optional target property to the link navigation type that allows specifying whether links should open in the same tab (_self) or a new tab (_blank), with _blank as the default.

  • Adds optional target property to the navigation link schema with enum validation
  • Updates the NavigationItem component to conditionally apply the target value
  • Documents the new property in the navigation configuration documentation

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/zudoku/src/lib/components/navigation/NavigationItem.tsx Implements conditional target assignment based on the new property
packages/zudoku/src/config/validators/InputNavigationSchema.ts Adds schema validation for the optional target property
docs/pages/docs/configuration/navigation.mdx Documents the new target property in the API reference

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

Preview build of published Zudoku package for commit 678a167.

See the deployment at: https://82aaef9c.cosmocargo-public-package.pages.dev

Note

This is a preview of the Cosmo Cargo example using the Zudoku package published to a local registry to ensure it'll be working when published to the public NPM registry.

Last updated: 2025-09-17T11:33:34.573Z

@ntotten ntotten merged commit 81efdb2 into main Sep 17, 2025
9 checks passed
@ntotten ntotten deleted the custom_target branch September 17, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants