Skip to content

Conversation

@martyndavies
Copy link
Contributor

@martyndavies martyndavies commented Aug 14, 2025

The secret component used on the API Keys settings page had double elements in it. Although not broken, the UI looked strange and confusing. This was reported in Discord.

CleanShot 2025-08-14 at 13 54 22

Copilot AI review requested due to automatic review settings August 14, 2025 12:13
@vercel
Copy link

vercel bot commented Aug 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Project Deployment Preview Updated (UTC)
zudoku-cosmo-cargo Ready Preview Aug 14, 2025 0:13am
zudoku-docs Ready Preview Aug 14, 2025 0:13am

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a UI issue where the API key secret component on the settings page displayed duplicated reveal and copy elements, creating confusion for users. The fix removes redundant UI controls by consolidating the reveal/copy functionality into the existing Secret component.

  • Removes duplicate reveal and copy buttons that were rendered outside the Secret component
  • Passes reveal state management props directly to the Secret component
  • Cleans up unused imports related to the removed duplicate functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@martyndavies martyndavies requested a review from dan-lee August 14, 2025 12:15
@github-actions
Copy link

Preview build of published Zudoku package for commit 9785a1a.

See the deployment at: https://e22a17e2.cosmocargo-public-package.pages.dev

Note

This is a preview of the Cosmo Cargo example using the Zudoku package published to a local registry to ensure it'll be working when published to the public NPM registry.

Last updated: 2025-08-14T12:15:45.712Z

Copy link
Contributor

@dan-lee dan-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 👏

@dan-lee dan-lee merged commit 3a391a0 into main Aug 15, 2025
9 checks passed
@dan-lee dan-lee deleted the fix/api-key-dupe branch August 15, 2025 07:25
@dan-lee dan-lee added the bug label Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants