Fix invalid underscore in domain names for OpenAPI bins #69
+117
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
OpenAPI bins were being created with
_oas
suffix, generating invalid domain names likehttps://12345678_oas.api.mockbin.io/
when using wildcard subdomains. This violates RFC 1035 DNS hostname standards, which prohibit underscores in domain names, causing TLS handshake failures in Java applications and other strict HTTP clients:Solution
Replace underscores with hyphens in OpenAPI bin IDs while maintaining full backward compatibility:
-oas
suffix (DNS compliant)_oas
suffix for existing binsChanges
Core Logic Updates
modules/handlers.ts
: Changed bin ID generation frombinId += "_oas"
tobinId += "-oas"
modules/utils.ts
: Updated regex pattern to accept both[-_]oas
formatsmodules/utils.ts
: EnhancedisOasBin()
to detect both underscore and hyphen variantsmodules/handlers.ts
: Updated YAML file handling to use consistent hyphen formatTest Coverage
Added comprehensive test suite covering:
Impact
Before:
https://12345678901234567890123456789012_oas.api.mockbin.io/
❌ (Invalid DNS)After:
https://12345678901234567890123456789012-oas.api.mockbin.io/
✅ (RFC 1035 compliant)This fix ensures OpenAPI bins work seamlessly with all HTTP clients while maintaining complete backward compatibility.
Original prompt
Fixes #67
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.